Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly improve visual when dragging entries to copy/move #9698

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

droidmonkey
Copy link
Member

Screenshots

image

Testing strategy

Tested on Windows with dark and light themes

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added this to the v2.7.6 milestone Aug 6, 2023
@droidmonkey droidmonkey requested a review from phoerious August 6, 2023 03:00
@droidmonkey droidmonkey force-pushed the fix/drag-drop-overlay branch 2 times, most recently from 84407bb to c3ed6fa Compare August 6, 2023 03:48
@droidmonkey droidmonkey force-pushed the fix/drag-drop-overlay branch from c3ed6fa to 0a0abd1 Compare August 6, 2023 04:01
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 64.66%. Comparing base (1b12c95) to head (0a0abd1).
Report is 237 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/entry/EntryView.cpp 0.00% 53 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9698      +/-   ##
===========================================
- Coverage    64.74%   64.66%   -0.08%     
===========================================
  Files          337      337              
  Lines        44656    44709      +53     
===========================================
  Hits         28910    28910              
- Misses       15746    15799      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@varjolintu varjolintu self-requested a review August 6, 2023 04:28
Copy link
Member

@varjolintu varjolintu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Tested on macOS and Fedora Linux.

@droidmonkey droidmonkey merged commit 15b8b5d into develop Aug 6, 2023
@droidmonkey droidmonkey deleted the fix/drag-drop-overlay branch August 6, 2023 19:26
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Aug 6, 2023
libf-de pushed a commit to libf-de/keepassxc-secretservice-dbus that referenced this pull request Aug 16, 2023
Release 2.7.6

Changes
- Significant improvement to visual when drag/drop entries [keepassxreboot#9698]
- Automatically prompt for Quick Unlock when showing unlock dialog [keepassxreboot#9697]
- Improve colorful lock icon and fix file MIME icon on KDE [keepassxreboot#9632]
- Ability to search by entry UUID [keepassxreboot#9571]
- Add challenge-response support for NitroKey 3 [keepassxreboot#9631]
- Auto-Type: Disable entry level Auto-Type when disabled at group/entry [keepassxreboot#9672]
- Browser: Show warning when adding duplicate URL's to entry [keepassxreboot#9588][keepassxreboot#9635]
- Browser: Improve error message when proxy cannot be found [keepassxreboot#9385]

Fixes
- Fix crash on exit on macOS [keepassxreboot#9620]
- Fix crash on search if entry doesn't have a group [keepassxreboot#9633]
- Fix several issues with Quick Unlock [keepassxreboot#9697]
- Enable save button when not auto-saving non-data changes [keepassxreboot#9634]
- Several UI/UX fixes [keepassxreboot#9647]
- Move toolbar back to top of window when disabling movement [keepassxreboot#9699]
- Browser: Fix closing password generator dialog with X button [keepassxreboot#9636]
- Browser: Fix handling of expired credentials [keepassxreboot#9595]
- Windows: Prevent white flicker when launching application [keepassxreboot#9637]
- Linux: Fix warning message about allow screencapture [keepassxreboot#9638]
- FdoSecrets: Fix access confirmation dialog showing even when disabled [keepassxreboot#9690]

# -----BEGIN PGP SIGNATURE-----
#
# iQJIBAABCAAyFiEE6A9nU7OzJX8m9B8ILPQdKqhDj5kFAmTb/usUHGphbmVrQGtl
# ZXBhc3N4Yy5vcmcACgkQLPQdKqhDj5l9vBAAmiCQR+L3ZLVq7CfXK+yOrCr1pV1J
# H6znrRe4SC5MR/dyrx+EVbkaPI0aWtW/NWa4REB9BUxkbXKIPy/9M6smj3xkjAqX
# YuYThNneRBFns9Rb5RyAIonwEXXmYHAWG2wdRXXFOnsb/Dxy9DYZK6+Ysbj55CQJ
# RBJ1y0IKCuajLvENW9zQQ/vTX0oxCQ2F9Fz7aTqGIoxW6NMhjTso7IPvKYWPzbNj
# FBOiI4kusL32pT5u+XwSUjmBvXrIEBjETYFTVgqesItAr0dFAgEh8f0jvuy8on8K
# ukVzD02JqavkMfwtDsvUVLdVdr1PJMOu4/qDodR1xC39VOjS9LQ6dK8rb/1Q4/MR
# cAXjBhNBZ0A5yq9XtdNvl8xYqkvYa/KcFuHUFwBoinLXtKLnh4aswDqk4caNeI4O
# O40Nk5J4J6Qgs89XIsQHkXkGTaPxuISHVeFWWqcpX9kRJhtlt5eIS6nDv8nGx8iq
# q65NfCldPckgmuIxeCX2lYtxieq09jAhD1/92eXsH1aNkZce4W1UcjGE58cduODd
# oXV7VCo0JUzkMky9I9/G+hAqWwLp94D5ewYG8yX2Oz2jwcoWvZSIZ6MtR+2NiYpL
# pFSFB/yoqWQOIVc9eHqCQl7rMMK66pJWwu7boxS22/xoNTAfzMwNtp8CmbLpqIhF
# 7lPQiiC2DnqfR0E=
# =l8kk
# -----END PGP SIGNATURE-----
# gpg: directory '/home/runner/.gnupg' created
# gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
# gpg: Signature made Tue Aug 15 22:40:43 2023 UTC
# gpg:                using RSA key E80F6753B3B3257F26F41F082CF41D2AA8438F99
# gpg:                issuer "[email protected]"
# gpg: Can't check signature: No public key
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging multiple entries blocks view of drop target
3 participants