Correct multiple snap issues #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to go in the documentation and in the FAQ page on the website. |
TheZ3ro
approved these changes
Sep 10, 2017
|
Btw, it looks like the new travis image causes asan to blow up. |
louib
approved these changes
Sep 16, 2017
|
@droidmonkey the travis build should be passing if you rebase on |
droidmonkey
force-pushed
the
hotfix/snap
branch
from
fe4a26c to
aa83988
Compare
droidmonkey
added a commit
that referenced
this pull request
Oct 1, 2017
- Corrected multiple snap issues [#934, #1011] - Corrected multiple custom icon issues [#708, #719, #994] - Corrected multiple Yubikey issues [#880] - Fixed single instance preventing load on occasion [#997] - Keep entry history when merging databases [#970] - Prevent data loss if passwords were mismatched [#1007] - Fixed crash after merge [#941] - Added configurable auto-type default delay [#703] - Unlock database dialog window comes to front [#663] - Translation and compiling fixes
|
Command line: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide fixes to multiple snap issues reported.
keepassxc.clicommand (snap limitation).Note: In order to use Yubikey you must manually connect the raw-usb interface using:
sudo snap connect keepassxc:raw-usb core:raw-usbHow has this been tested?
Manually and unit tests.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]