Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various accessibility issues #9138

Merged
merged 6 commits into from
Apr 16, 2023
Merged

Fix various accessibility issues #9138

merged 6 commits into from
Apr 16, 2023

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Feb 19, 2023

Enable buddy fields in group and entry edit pages

  • Fixes Accessibility issues: keyboard trap in entry window #9060
  • You can now press Alt + [letter] to skip between fields on the group and entry edit pages.
  • Also move the expire checkbox to the right hand column and use the standard eye icon button for notes reveal. Only show notes reveal button if the hide notes setting is enabled.

Fix overflow of text in default auto-type sequence preview

Add copy title shortcut (Ctrl + I)

Fix issues with menu actions being enabled incorrectly on first load / database lock (see screenshot)

Add F6 shortcut to focus on search
Closes #9163

Add accessibility description to password widget to explain how to hide/show passwords and open the generator
Closes #9059

Screenshots

image

image

image

image

Testing strategy

Tested on Windows

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.10 🎉

Comparison is base (ba1bbd3) 64.87% compared to head (55918e6) 64.98%.

❗ Current head 55918e6 differs from pull request most recent head 9505669. Consider uploading reports for the commit 9505669 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9138      +/-   ##
===========================================
+ Coverage    64.87%   64.98%   +0.10%     
===========================================
  Files          342      342              
  Lines        44456    44389      -67     
===========================================
+ Hits         28840    28842       +2     
+ Misses       15616    15547      -69     
Impacted Files Coverage Δ
src/gui/entry/EditEntryWidget.cpp 70.39% <75.00%> (-0.24%) ⬇️
src/gui/MainWindow.cpp 71.46% <100.00%> (+0.27%) ⬆️

... and 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey marked this pull request as ready for review March 30, 2023 11:25
* Fixes #9060
* You can now press Alt + [letter] to skip between fields on the group and entry edit pages.

* Also move the expire checkbox to the right hand column and use the standard eye icon button for notes reveal. Only show notes reveal button if the hide notes setting is enabled.
@droidmonkey droidmonkey merged commit 52775d4 into develop Apr 16, 2023
@droidmonkey droidmonkey deleted the fix/accessibility branch April 16, 2023 01:35
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Apr 16, 2023
droidmonkey added a commit that referenced this pull request Apr 16, 2023
Enable buddy fields in group and entry edit pages
* Fixes #9060, you can now press Alt + [letter] to skip between fields on the group and entry edit pages.
* Move the expire checkbox to the right hand column and use the standard eye icon button for notes reveal. Only show notes reveal button if the hide notes setting is enabled.

Fix overflow of text in default auto-type sequence preview
* Fixes #9083

Add copy title shortcut (Ctrl + I)
* Closes #9109

Fix issues with menu actions being enabled incorrectly

Add accessibility description to password widget to explain how to hide/show passwords and open the generator
* Closes #9059

Add F6 shortcut to focus search
* Closes #9163
Perlover added a commit to Perlover/keepassxc that referenced this pull request May 18, 2023
Release 2.7.5

- Add menu option to allow screenshots [keepassxreboot#8841]
- Add support for Botan 3 [keepassxreboot#9388]
- Increase max TOTP step to 24 hours [keepassxreboot#9149]
- Improve HTML export layout [keepassxreboot#8987]
- Turn search reset off by default [keepassxreboot#9153]
- Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148]
- Hide group column header choice when not in search [keepassxreboot#9171]
- Improve look of KeePassXC logo and icons [keepassxreboot#9355]
- Add keyboard shortcuts for app and database settings [keepassxreboot#9007]
- Hide rename button from attachments preview panel [keepassxreboot#8842]
- Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430]

- Fix crash when search clears while creating new entry [keepassxreboot#9230]
- Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006]
- Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778]
- Fix canceling quick unlock when it is unavailable [keepassxreboot#9034]
- Set password input field font correctly [keepassxreboot#8732]
- Greatly improve performance when rendering entry view [keepassxreboot#9398]
- Fix various accessibility issues [keepassxreboot#9138]
- Fix arrows size when expand/collapse a group [keepassxreboot#9096]
- Select the clone instead of the original after cloning an entry [keepassxreboot#9070]
- Fix bugs with preview widget [keepassxreboot#9170]
- Fix status bar update when switching to other DB [keepassxreboot#9073]
- Fix database settings spin box bug [keepassxreboot#9101]
- Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839]
- Fix TOTP QR code maintaining square ratio [keepassxreboot#9027]
- Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752]
- Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889]
- Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205]
- Allow setting default file open directory with env var [keepassxreboot#9192]
- SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968]
- Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835]
- MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066]
- MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615]
- Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment