Detect session lock on Xfce/XUbuntu 16.04 #910
Conversation
| @@ -51,6 +52,15 @@ ScreenLockListenerDBus::ScreenLockListenerDBus(QWidget *parent): | |||
| this, //receiver | |||
| SLOT(logindPrepareForSleep(bool))); | |||
|
|
|||
| QString sessionId = QProcessEnvironment::systemEnvironment().value("XDG_SESSION_ID"); | |||
There was a problem hiding this comment.
I don't think this will open us to exploits, but I'd feel better if you validated this to be an integer.
|
@Typz is this still under development? |
|
sorry, I saw the approval and missed the change request, then forgot about this... I'll fix it ASAP! |
|
actually, XDG_SESSION_ID is not an integer: on my setup (XUbuntu 17.04) it is 'c2'. |
|
@Typz no problem :) PS: you will need to rebase on develop |
|
Oh, it's Can you rebase on develop anyway so I can merge? |
francoisferrand
force-pushed
the
xfce-lock
branch
from
3096b47 to
7edb3c6
Compare
|
done |
|
Right now, it's c2 as well here. But I'm certain that it was a number when I added that review note. c2 could also still be a (hex) number. |
|
The manual says (https://www.freedesktop.org/software/systemd/man/pam_systemd.html)
In the source code Searching online most of the time is in the range 1-7 or in range c1-c7 |
|
Ok, then leave it as is. |
|
@Typz rebase please 😉 |
The current code does not work with XUbuntu 16.04, which uses light-locker to lock the screen. I am not using a screensaver, but I suspect the screensaver activation may have been detected by the existing events, and using it could thus mask the issue.
francoisferrand
force-pushed
the
xfce-lock
branch
from
7edb3c6 to
263bee3
Compare
|
Done |
|
Thanks |
- Add support for KDBX 4.0, Argon2 and ChaCha20 [#148, #1179, #1230, #1494] - Add SSH Agent feature [#1098, #1450, #1463] - Add preview panel with details of the selected entry [#879, #1338] - Add more and configurable columns to entry table and allow copying of values by double click [#1305] - Add KeePassXC-Browser API as a replacement for KeePassHTTP [#608] - Deprecate KeePassHTTP [#1392] - Add support for Steam one-time passwords [#1206] - Add support for multiple Auto-Type sequences for a single entry [#1390] - Adjust YubiKey HMAC-SHA1 challenge-response key generation for KDBX 4.0 [#1060] - Replace qHttp with cURL for website icon downloads [#1460] - Remove lock file [#1231] - Add option to create backup file before saving [#1385] - Ask to save a generated password before closing the entry password generator [#1499] - Resolve placeholders recursively [#1078] - Add Auto-Type button to the toolbar [#1056] - Improve window focus handling for Auto-Type dialogs [#1204, #1490] - Auto-Type dialog and password generator can now be exited with ESC [#1252, #1412] - Add optional dark tray icon [#1154] - Add new "Unsafe saving" option to work around saving problems with file sync services [#1385] - Add IBus support to AppImage and additional image formats to Windows builds [#1534, #1537] - Add diceware password generator to CLI [#1406] - Add --key-file option to CLI [#816, #824] - Add DBus interface for opening and closing KeePassXC databases [#283] - Add KDBX compression options to database settings [#1419] - Discourage use of old fixed-length key files in favor of arbitrary files [#1326, #1327] - Correct reference resolution in entry fields [#1486] - Fix window state and recent databases not being remembered on exit [#1453] - Correct history item generation when configuring TOTP for an entry [#1446] - Correct multiple TOTP bugs [#1414] - Automatic saving after every change is now a default [#279] - Allow creation of new entries during search [#1398] - Correct menu issues on macOS [#1335] - Allow compilation on OpenBSD [#1328] - Improve entry attachments view [#1139, #1298] - Fix auto lock for Gnome and Xfce [#910, #1249] - Don't remember key files in file dialogs when the setting is disabled [#1188] - Improve database merging and conflict resolution [#807, #1165] - Fix macOS pasteboard issues [#1202] - Improve startup times on some platforms [#1205] - Hide the notes field by default [#1124] - Toggle main window by clicking tray icon with the middle mouse button [#992] - Fix custom icons not copied over when databases are merged [#1008] - Allow use of DEL key to delete entries [#914] - Correct intermittent crash due to stale history items [#1527] - Sanitize newline characters in title, username and URL fields [#1502] - Reopen previously opened databases in correct order [#774] - Use system's zxcvbn library if available [#701] - Implement various i18n improvements [#690, #875, #1436]
phoerious
added
pr: new feature
The current code does not work with XUbuntu 16.04, which uses
light-locker to lock the screen.
I am not using a screensaver, but I suspect the screensaver activation
may have been detected by the existing events, and using it could thus
mask the issue.