Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exported html layout #8987

Merged

Conversation

dmaslenko
Copy link
Contributor

@dmaslenko dmaslenko commented Jan 13, 2023

Improve the exported html page to have more readable output and utilize more page space. It is a follow up of the #7769 issue.

What done

  • The title was moved from dedicated column to a table caption.
  • Added a delimiter between title and entity body.
  • The font size for notes was changed from medium to small.
  • The notes order was moved to the end.
  • The table margin and width were adjusted to fit into screen and print pages.

Screenshots

An example of a single entity with huge notes:

ImprovedHtmlPage

An example of many entities with small notes:

ImprovedHtmlPage2

An example of print page:

ImprovedPrintPage

Manual testing

  • Created a test database with some entries with different notes.
  • Exported the database into HTML page.
  • Opened the generated html page by Firefox, Brave browsers.
  • Made sure the formatting is good.

Unit testing

  • Not applicable

Type of change

  • ✅ New feature (change that adds functionality)

[What]
  1) The title was moved from dedicated column to a table caption.
  2) The font size for notes was changed from medium to small.
  3) The notes order was moved to the end.
  4) The table margin and width were adjusted to fit into screen and
     print pages.

[Why]
  To have more readable output and utilize more page space.
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Base: 64.41% // Head: 64.40% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e570137) compared to base (3e3e87d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8987      +/-   ##
===========================================
- Coverage    64.41%   64.40%   -0.01%     
===========================================
  Files          341      341              
  Lines        44257    44261       +4     
===========================================
  Hits         28505    28505              
- Misses       15752    15756       +4     
Impacted Files Coverage Δ
src/gui/HtmlExporter.cpp 0.00% <0.00%> (ø)
src/core/FileWatcher.cpp 85.54% <0.00%> (-1.20%) ⬇️
src/core/Entry.cpp 82.52% <0.00%> (-0.20%) ⬇️
src/gui/osutils/nixutils/NixUtils.cpp 35.48% <0.00%> (+1.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey added this to the v2.7.5 milestone Jan 29, 2023
@droidmonkey droidmonkey self-requested a review January 29, 2023 16:01
@droidmonkey droidmonkey merged commit 5226a59 into keepassxreboot:develop Jan 29, 2023
@droidmonkey
Copy link
Member

This is much better looking, great work!

@dmaslenko dmaslenko deleted the feature/new_exported_html_layout branch January 30, 2023 04:33
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Feb 18, 2023
@droidmonkey droidmonkey mentioned this pull request Feb 23, 2023
@thyxNY
Copy link

thyxNY commented Mar 10, 2023

@droidmonkey
When is version 2.7.5 scheduled to be released?
I want to print a lot of items from Keepassxc.
Will the release be before April 15th?

@michaelk83
Copy link

There is no schedule. You can use a development snapshot if you need the latest features. https://snapshot.keepassxc.org/

@thyxNY
Copy link

thyxNY commented Mar 10, 2023

@michaelk83
For printing a snapshot is a very good solution! THANKS!!!

Perlover added a commit to Perlover/keepassxc that referenced this pull request May 18, 2023
Release 2.7.5

- Add menu option to allow screenshots [keepassxreboot#8841]
- Add support for Botan 3 [keepassxreboot#9388]
- Increase max TOTP step to 24 hours [keepassxreboot#9149]
- Improve HTML export layout [keepassxreboot#8987]
- Turn search reset off by default [keepassxreboot#9153]
- Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148]
- Hide group column header choice when not in search [keepassxreboot#9171]
- Improve look of KeePassXC logo and icons [keepassxreboot#9355]
- Add keyboard shortcuts for app and database settings [keepassxreboot#9007]
- Hide rename button from attachments preview panel [keepassxreboot#8842]
- Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430]

- Fix crash when search clears while creating new entry [keepassxreboot#9230]
- Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006]
- Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778]
- Fix canceling quick unlock when it is unavailable [keepassxreboot#9034]
- Set password input field font correctly [keepassxreboot#8732]
- Greatly improve performance when rendering entry view [keepassxreboot#9398]
- Fix various accessibility issues [keepassxreboot#9138]
- Fix arrows size when expand/collapse a group [keepassxreboot#9096]
- Select the clone instead of the original after cloning an entry [keepassxreboot#9070]
- Fix bugs with preview widget [keepassxreboot#9170]
- Fix status bar update when switching to other DB [keepassxreboot#9073]
- Fix database settings spin box bug [keepassxreboot#9101]
- Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839]
- Fix TOTP QR code maintaining square ratio [keepassxreboot#9027]
- Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752]
- Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889]
- Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205]
- Allow setting default file open directory with env var [keepassxreboot#9192]
- SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968]
- Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835]
- MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066]
- MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615]
- Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export: HTML pr: backported Pull request backported to previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants