Add menu option to allow screenshots

[droidmonkey]

• Fix Add view menu option to allow screenshots for temporary period of time #7580
• Also refactor the code to move everything into MainWindow

Screenshots

Testing strategy

Tested on Windows

Type of change

• ✅ New feature (change that adds functionality)

[codecov-commenter]

Codecov Report

Base: 64.84% // Head: 64.84% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (9a943f0) compared to base (cc35bf2).
Patch coverage: 46.67% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8841      +/-   ##
===========================================
- Coverage    64.84%   64.84%   -0.01%     
===========================================
  Files          342      342              
  Lines        44408    44421      +13     
===========================================
+ Hits         28796    28801       +5     
- Misses       15612    15620       +8     

Impacted Files	Coverage Δ
src/gui/MainWindow.cpp	71.24% <42.86%> (-0.38%)	⬇️
src/gui/osutils/OSUtilsBase.cpp	100.00% <100.00%> (+60.00%)	⬆️
src/core/FileWatcher.cpp	85.54% <0.00%> (-1.20%)	⬇️
src/core/Entry.cpp	82.42% <0.00%> (-0.30%)	⬇️
src/gui/osutils/nixutils/NixUtils.h	100.00% <0.00%> (+50.00%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[droidmonkey]

@phoerious would appreciate a review of this one

[droidmonkey]

This is a relatively benign change (and rather useful) so will merge it in.

[LayersOfAbstraction]

@phoerious would appreciate a review of this one

Hi, thank you, really appreciate the feature. I prefer to actually start it in the command line as it is safer with the --allow-screencapture parameter so I don't forget to disable it after I finish the screen capture. I feel that view menu option you made should be set to disable after closing with a pop-up advising the user so they know it is intentional.

It could say something like:

As a security measure, the Allow Screen Capture option will automatically be disabled after closure.

[Scrxtchy]

@phoerious would appreciate a review of this one

Hi, thank you, really appreciate the feature. I prefer to actually start it in the command line as it is safer with the --allow-screencapture parameter so I don't forget to disable it after I finish the screen capture. I feel that view menu option you made should be set to disable after closing with a pop-up advising the user so they know it is intentional.

It could say something like:

As a security measure, the Allow Screen Capture option will automatically be disabled after closure.

Funny enough, I stumbled across the launch argument from the documentation just now. I added it to my shortcut so I could start it with the configuration as it was causing nvidia shadowplay to not record anything due to the protected content flag. This does feel much safer than just adding in a permanent configuration for this but it's not well known about (and nvidia has no visible error for these things lol, took me a while to realise this was the case)