Add preview panel for entries and groups, closes #454 and #558 #879

TheZ3ro · 2017-08-17T21:17:24Z

Description

This PR add a preview panel for entires and groups and add/fix some minor things:

Fixed Entry.cpp resolveUrl when the url is empty
Added Group.cpp hierarchy that return a QStringList of parent group names
Added chronometer icon for TOTP
Details panel is visible by default (can be hidden permanently in settings, temporary with the slider or the X button)
Passwords are hidden by default (can be changed in settings)
Show Autotype association for entries (suggested by @droidmonkey )
Protected attributes are shown as [PROTECTED]
Root group isn't shown in entries' path
Hi-res icons are resized to 16x16 to don't mess up the layout
Remove Creation/Access/Modification data (suggested by @andusvan)
Remove Attributes and Autotype Tabs for Groups (they can't have those) (suggested by @andusvan)
Selected tab isn't changed when selecting a new entry/group (suggested by @andusvan)

Some info on the preview panel:

The preview panel can be disabled (and hidden) in the settings, it can also be hidden using the spacer above it.
It can be temporary hidden using the X icon, the panel will be visible again when a new Entry/Group is clicked.

You must click on an Entry/Group to display its info on the panel, this is due to a bug when using both click and change signals (currently the change signals are commented, line 196-198 src/gui/DatabaseWidget.cpp)

You can decide to disable/hide passwords in the preview panel from the settings, in this case the visualized password will be 4 dot.

Motivation and context

Closes #454 and #558

How has this been tested?

Manual gui testing

Screenshots (if appropriate):

Screenshots here #454 (comment)

Types of changes

✅ New feature (non-breaking change which adds functionality)

Checklist:

✅ I have read the CONTRIBUTING document. [REQUIRED]
✅ My code follows the code style of this project. [REQUIRED]
✅ All new and existing tests passed. [REQUIRED]
✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

phoerious

I don't like the password being in an input field. Makes the whole layout rather inconsistent and visually overwhelming / confusing.

phoerious · 2017-08-17T22:06:15Z

Also you may want to adjust the spacing a little. The second and third column are way closer to each other than the first and second and the third and fourth. The "Notes" label should also be consistent with the other labels (i.e., bold and top-aligned).

droidmonkey

When navigating between entries with the up/down arrow keys the preview pane does not update.

TheZ3ro · 2017-08-18T20:58:41Z

@phoerious the spacing is due to the PasswordEdit and the visibility button, there isn't much I can do.

Using a label for the password will bring the same problem as the URL since most of my password are >40 char and such length will broke the layout on small window size.
Should I short passwords like it's done with URLs?

@droidmonkey like I said in the first message, enabling that will bring some problems with guitest that I can't reproduce manually

phoerious · 2017-08-18T21:02:58Z

Show the password as three asterisks or bullets, don't use the password edit. Add an extra button to reveal it. Maybe add some sort of context pop-up on hover for all entries to show a non-elided full-length version.

TheZ3ro · 2017-08-30T23:01:27Z

I've fixed the navigating issue, the notes label and the password field. Should be good now 😉

droidmonkey · 2017-08-31T03:22:04Z

I'll take a look tomorrow but there is still considerable whitespace issues (as of the last screenshot) and questionable need to display creation/access times.

droidmonkey · 2017-09-27T22:11:14Z

Looks great! Found an issue though:

The new hi-res icons get cut-off and enlarge the view.

Also, do we want to repeat the root group's folder in the path? It's technically not a subfolder and could be confusing. The password field is also unmasked.

Suggestion: It might be nice to add an auto-type tab that lists the currently assigned auto-type window/sequence combos for the entry.

TheZ3ro · 2017-09-28T09:44:09Z

The new hi-res icons get cut-off and enlarge the view.

Woops, I didn't tested with hi-res icon

Also, do we want to repeat the root group's folder in the path?

You mean removing the first / ?

The password field is also unmasked.

There should be an option in Settings > Security > Hide passwords in the preview panel, by default they are always visible

Suggestion: It might be nice to add an auto-type tab that lists the currently assigned auto-type window/sequence combos for the entry.

Nice, I will work on this

droidmonkey · 2017-09-28T16:09:10Z

I meant removing the "NewDatabase" label

TheZ3ro · 2017-09-28T16:30:47Z

Oh ok got it. I will work on this in the next few days

TheZ3ro · 2017-10-24T11:01:09Z

Rebased on develop, ready for review

phoerious

Found a few more issues that need fixing.

phoerious · 2017-10-24T11:11:34Z

src/gui/DetailsWidget.cpp

+        for (const QString& key : customAttributes) {
+            QString value = m_currentEntry->attributes()->value(key);
+            if (m_currentEntry->attributes()->isProtected(key)) {
+                value = "<i>[PROTECTED]</i>";


Not translated. Re-use locale string from edit entry screen (without the i tags).

In the edit entry it's tr("[PROTECTED] Press reveal to view or edit")

I will separate the 2 string so we can re-use [PROTECTED]

phoerious · 2017-10-24T11:13:18Z

src/gui/DetailsWidget.cpp

+
+    m_ui->autotypeTree->clear();
+    AutoTypeAssociations* autotypeAssociations = m_currentEntry->autoTypeAssociations();
+    QList<QTreeWidgetItem *> items;


Remove space before *.

phoerious · 2017-10-24T11:14:47Z

src/gui/DetailsWidget.cpp

+    QString newurl = "";
+    if (url.length() > 60) {
+        newurl.append(url.left(20));
+        newurl.append("...");


This should be an ellipsis character (U+2026).

phoerious · 2017-10-24T11:15:00Z

src/gui/DetailsWidget.cpp

+    QString newpassword = "";
+    if (password.length() > 60) {
+        newpassword.append(password.left(50));
+        newpassword.append("...");


phoerious · 2017-10-24T14:54:49Z

src/gui/entry/EditEntryWidget.cpp

@@ -632,7 +632,7 @@ void EditEntryWidget::displayAttribute(QModelIndex index, bool showProtected)
    if (index.isValid()) {
        QString key = m_attributesModel->keyByIndex(index);
        if (showProtected) {
-            m_advancedUi->attributesEdit->setPlainText(tr("[PROTECTED] Press reveal to view or edit"));
+            m_advancedUi->attributesEdit->setPlainText(tr("[PROTECTED]")+" "+tr("Press reveal to view or edit"));


Please add spaces between operators or use .append().

TheZ3ro · 2017-10-25T10:23:17Z

What is missing before merge?

droidmonkey · 2017-10-26T03:34:38Z

Let's merge this, we can make tweaks later as we use it more.

dprime · 2018-01-23T17:09:54Z

I know this is closed, but I've got some feedback on the layout of this. In the old keepass2, I really liked and used a lot the notes fields for storing bits and pieces. Being able to view the notes in the preview panel with 1 click is a really nice feature and something that stops me moving from the old keepass2 to keepassxc. With this implementation, the notes field is hidden by default. Would it not be more usable to display everything in one, like the old keepass2?

droidmonkey · 2018-01-23T17:24:41Z

Notes are visible in a tab, you can select that tab and it will persist between entry selections.

- Add support for KDBX 4.0, Argon2 and ChaCha20 [#148, #1179, #1230, #1494] - Add SSH Agent feature [#1098, #1450, #1463] - Add preview panel with details of the selected entry [#879, #1338] - Add more and configurable columns to entry table and allow copying of values by double click [#1305] - Add KeePassXC-Browser API as a replacement for KeePassHTTP [#608] - Deprecate KeePassHTTP [#1392] - Add support for Steam one-time passwords [#1206] - Add support for multiple Auto-Type sequences for a single entry [#1390] - Adjust YubiKey HMAC-SHA1 challenge-response key generation for KDBX 4.0 [#1060] - Replace qHttp with cURL for website icon downloads [#1460] - Remove lock file [#1231] - Add option to create backup file before saving [#1385] - Ask to save a generated password before closing the entry password generator [#1499] - Resolve placeholders recursively [#1078] - Add Auto-Type button to the toolbar [#1056] - Improve window focus handling for Auto-Type dialogs [#1204, #1490] - Auto-Type dialog and password generator can now be exited with ESC [#1252, #1412] - Add optional dark tray icon [#1154] - Add new "Unsafe saving" option to work around saving problems with file sync services [#1385] - Add IBus support to AppImage and additional image formats to Windows builds [#1534, #1537] - Add diceware password generator to CLI [#1406] - Add --key-file option to CLI [#816, #824] - Add DBus interface for opening and closing KeePassXC databases [#283] - Add KDBX compression options to database settings [#1419] - Discourage use of old fixed-length key files in favor of arbitrary files [#1326, #1327] - Correct reference resolution in entry fields [#1486] - Fix window state and recent databases not being remembered on exit [#1453] - Correct history item generation when configuring TOTP for an entry [#1446] - Correct multiple TOTP bugs [#1414] - Automatic saving after every change is now a default [#279] - Allow creation of new entries during search [#1398] - Correct menu issues on macOS [#1335] - Allow compilation on OpenBSD [#1328] - Improve entry attachments view [#1139, #1298] - Fix auto lock for Gnome and Xfce [#910, #1249] - Don't remember key files in file dialogs when the setting is disabled [#1188] - Improve database merging and conflict resolution [#807, #1165] - Fix macOS pasteboard issues [#1202] - Improve startup times on some platforms [#1205] - Hide the notes field by default [#1124] - Toggle main window by clicking tray icon with the middle mouse button [#992] - Fix custom icons not copied over when databases are merged [#1008] - Allow use of DEL key to delete entries [#914] - Correct intermittent crash due to stale history items [#1527] - Sanitize newline characters in title, username and URL fields [#1502] - Reopen previously opened databases in correct order [#774] - Use system's zxcvbn library if available [#701] - Implement various i18n improvements [#690, #875, #1436]

TheZ3ro added the new feature label Aug 17, 2017

TheZ3ro added this to the v2.3.0 milestone Aug 17, 2017

TheZ3ro requested a review from a team August 17, 2017 21:17

phoerious requested changes Aug 17, 2017

View reviewed changes

droidmonkey added the needs work label Aug 18, 2017

droidmonkey self-requested a review August 18, 2017 02:05

droidmonkey requested changes Aug 18, 2017

View reviewed changes

TheZ3ro force-pushed the feature/preview-panel branch from 6e9f0ab to 51bf314 Compare August 30, 2017 22:53

TheZ3ro removed the needs work label Sep 4, 2017

ccoenen mentioned this pull request Sep 6, 2017

Feature request: UI improvements #924

Closed

TheZ3ro force-pushed the feature/preview-panel branch 2 times, most recently from 88216d9 to 5d6f399 Compare September 29, 2017 19:31

TheZ3ro mentioned this pull request Sep 29, 2017

Add preview pane #454

Closed

TheZ3ro force-pushed the feature/preview-panel branch from 12f166b to 603aeb4 Compare September 29, 2017 20:44

TheZ3ro force-pushed the feature/preview-panel branch 2 times, most recently from b37bde9 to c0f9d54 Compare October 24, 2017 10:17

phoerious requested changes Oct 24, 2017

View reviewed changes

phoerious reviewed Oct 24, 2017

View reviewed changes

TheZ3ro force-pushed the feature/preview-panel branch from e2ce318 to e3e3053 Compare October 24, 2017 15:18

phoerious approved these changes Oct 24, 2017

View reviewed changes

TheZ3ro force-pushed the feature/preview-panel branch 2 times, most recently from bedf5b2 to 275bd38 Compare October 24, 2017 18:57

droidmonkey approved these changes Oct 26, 2017

View reviewed changes

TheZ3ro and others added 10 commits October 26, 2017 12:19

add preview panel for entries and groups

1a87e30

fix group parent, add details update by keyboard

0e6fedc

fix notes label

4a5fc21

layout update

eb65822

remove root group from path, resize icons to 16x16

d0f8d43

fix group layout, add autotype associations

9279bf7

remember last selected tab, hide passwords by default

71ae2a3

fix protected transalation

8416d69

Resolve placeholders in entry details url

b9fd609

Cleaned up url display code

f3d85ae

TheZ3ro force-pushed the feature/preview-panel branch from 04f4624 to f3d85ae Compare October 26, 2017 10:19

TheZ3ro merged commit 3b9ffa1 into develop Oct 26, 2017

TheZ3ro deleted the feature/preview-panel branch October 26, 2017 10:40

This was referenced Oct 28, 2017

GUI & layout issue in the preview panel #1135

Closed

Prevent crash with empty database #1145

Merged

TheZ3ro mentioned this pull request Nov 15, 2017

[Feature] Access/read the notes quickly #558

Closed

yan12125 mentioned this pull request Dec 23, 2017

Fix font size of URL label in the preview panel #1316

Merged

phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add preview panel for entries and groups, closes #454 and #558 #879

Add preview panel for entries and groups, closes #454 and #558 #879

TheZ3ro commented Aug 17, 2017 •

edited

Loading

phoerious left a comment

phoerious commented Aug 17, 2017 •

edited

Loading

droidmonkey left a comment

TheZ3ro commented Aug 18, 2017

phoerious commented Aug 18, 2017

TheZ3ro commented Aug 30, 2017

droidmonkey commented Aug 31, 2017

droidmonkey commented Sep 27, 2017 •

edited

Loading

TheZ3ro commented Sep 28, 2017

droidmonkey commented Sep 28, 2017

TheZ3ro commented Sep 28, 2017

TheZ3ro commented Oct 24, 2017

phoerious left a comment

phoerious Oct 24, 2017

TheZ3ro Oct 24, 2017

phoerious Oct 24, 2017

phoerious Oct 24, 2017

phoerious Oct 24, 2017

phoerious Oct 24, 2017

TheZ3ro commented Oct 25, 2017

droidmonkey commented Oct 26, 2017

dprime commented Jan 23, 2018

droidmonkey commented Jan 23, 2018

Add preview panel for entries and groups, closes #454 and #558 #879

Add preview panel for entries and groups, closes #454 and #558 #879

Conversation

TheZ3ro commented Aug 17, 2017 • edited Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

phoerious left a comment

Choose a reason for hiding this comment

phoerious commented Aug 17, 2017 • edited Loading

droidmonkey left a comment

Choose a reason for hiding this comment

TheZ3ro commented Aug 18, 2017

phoerious commented Aug 18, 2017

TheZ3ro commented Aug 30, 2017

droidmonkey commented Aug 31, 2017

droidmonkey commented Sep 27, 2017 • edited Loading

TheZ3ro commented Sep 28, 2017

droidmonkey commented Sep 28, 2017

TheZ3ro commented Sep 28, 2017

TheZ3ro commented Oct 24, 2017

phoerious left a comment

Choose a reason for hiding this comment

phoerious Oct 24, 2017

Choose a reason for hiding this comment

TheZ3ro Oct 24, 2017

Choose a reason for hiding this comment

phoerious Oct 24, 2017

Choose a reason for hiding this comment

phoerious Oct 24, 2017

Choose a reason for hiding this comment

phoerious Oct 24, 2017

Choose a reason for hiding this comment

phoerious Oct 24, 2017

Choose a reason for hiding this comment

TheZ3ro commented Oct 25, 2017

droidmonkey commented Oct 26, 2017

dprime commented Jan 23, 2018

droidmonkey commented Jan 23, 2018

TheZ3ro commented Aug 17, 2017 •

edited

Loading

phoerious commented Aug 17, 2017 •

edited

Loading

droidmonkey commented Sep 27, 2017 •

edited

Loading