Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add entry 2 months to preset menu #8687

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

thuvh
Copy link
Contributor

@thuvh thuvh commented Oct 28, 2022

In preset menu of expiration password, there are 3 options, 1, 3 and 6 months. Normally, 90 days is used set for a policy. Hence, sometime password expired before this app. Add 2 months option allow me to set new password before expired.

Screenshots

No screenshot

Testing strategy

I haven't test yet.

Type of change

  • ✅ New feature (change that adds functionality)

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (03f11ce) to head (2838cea).
Report is 347 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8687      +/-   ##
===========================================
+ Coverage    64.26%   64.28%   +0.02%     
===========================================
  Files          341      341              
  Lines        44334    44335       +1     
===========================================
+ Hits         28488    28498      +10     
+ Misses       15846    15837       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@phoerious phoerious added this to the v2.8.0 milestone Oct 28, 2022
@phoerious phoerious merged commit ef51065 into keepassxreboot:develop Oct 28, 2022
@phoerious
Copy link
Member

Thanks!

@phoerious phoerious modified the milestones: v2.8.0, v2.7.4 Oct 28, 2022
@phoerious phoerious added the pr: backport pending Pull request yet to be backported to a previous release label Oct 28, 2022
pull bot pushed a commit to Tiamat-Tech/keepassxc that referenced this pull request Oct 28, 2022
@michaelk83
Copy link

Rather than adding more and more presets, this should really be made customizable: #6800

pull bot pushed a commit to tigerwill90/keepassxc that referenced this pull request Oct 28, 2022
droidmonkey pushed a commit that referenced this pull request Oct 29, 2022
@droidmonkey droidmonkey mentioned this pull request Oct 29, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 29, 2022
droidmonkey pushed a commit that referenced this pull request Oct 29, 2022
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants