Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launching proxy service with Flatpak #8680

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested using 2.7.3 Flatpak distribution with manual edits to the browser json file. Will test with a custom flatpak build of this branch as well.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added feature: Browser distribution: Flatpak pr: backport pending Pull request yet to be backported to a previous release labels Oct 27, 2022
@droidmonkey droidmonkey added this to the v2.7.4 milestone Oct 27, 2022
@droidmonkey droidmonkey requested a review from phoerious October 27, 2022 11:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 64.30% // Head: 64.28% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (4c41ca2) compared to base (422fd91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8680      +/-   ##
===========================================
- Coverage    64.30%   64.28%   -0.02%     
===========================================
  Files          341      341              
  Lines        44330    44330              
===========================================
- Hits         28502    28495       -7     
- Misses       15828    15835       +7     
Impacted Files Coverage Δ
src/browser/NativeMessageInstaller.cpp 24.17% <ø> (ø)
src/gui/Clipboard.cpp 78.95% <0.00%> (-7.02%) ⬇️
src/core/FileWatcher.cpp 86.75% <0.00%> (-1.20%) ⬇️
src/core/Entry.cpp 82.52% <0.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey force-pushed the fix/flatpak-proxy-launch branch from 4c41ca2 to cc7506b Compare October 28, 2022 11:32
@droidmonkey droidmonkey force-pushed the fix/flatpak-proxy-launch branch from cc7506b to 676455e Compare October 29, 2022 13:30
@droidmonkey droidmonkey merged commit 3efad4e into develop Oct 29, 2022
@droidmonkey droidmonkey deleted the fix/flatpak-proxy-launch branch October 29, 2022 13:54
@droidmonkey droidmonkey mentioned this pull request Oct 29, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 29, 2022
@prometoys
Copy link

Hi,

it seems this doesn't work with Firefox 106.0.5 from Snap with WebExtensions Portal (which work with keepassxc from deb). If I observed it correctly, Keepassxc-browser from Firefox-Snap triggers keepassxc-binary without any args.

If I change path in the json to /var/lib/flatpak/app/org.keepassxc.KeePassXC/current/active/files/bin/keepassxc-proxy, then the communication between Firefox-Snap and Keepassxc-Flatpak works.

I'm not sure where is the best place to open a new bugreport.

Best

Keywan

@ivanov17
Copy link

Hello, @droidmonkey!

I'm using Google Chrome 108 and KeePassXC 2.7.4 on Fedora Silverblue 37, both are flatpaked.

It doesn't seem to work, because I get a message that the key exchange was not successful.

I tried setting the path value in the org.keepassxc.keepassxc_browser.json file to

/home/user/.local/share/flatpak/exports/bin/org.keepassxc.KeePassXC

then directly to

/home/user/.local/share/flatpak/app/org.keepassxc.KeePassXC/current/active/files/bin/keepassxc-wrapper

and finally to

/home/user/.local/share/flatpak/app/org.keepassxc.KeePassXC/current/active/files/bin/keepassxc-proxy

but nothing works.

I also tried to build keepassxc-proxy-rust and connect to KeePassXC through it, but that doesn't work either.

I seem to be doing something wrong, could you please guide me how to do it right?

Thank you.

@droidmonkey
Copy link
Member Author

I don't think Chrome flatpak (or snap) supports native messaging yet. Only Firefox does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distribution: Flatpak feature: Browser pr: backported Pull request backported to previous release
Projects
None yet
5 participants