Fix crash on macOS when unlocking database #8676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
platform: macOS
crash 💥
feature: QuickUnlock
pr: backport pending
phoerious
approved these changes
Oct 27, 2022
|
I'll test it later, but looks good to me. |
Codecov ReportBase: 64.30% // Head: 64.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #8676 +/- ##
===========================================
- Coverage 64.30% 64.28% -0.02%
===========================================
Files 341 341
Lines 44330 44330
===========================================
- Hits 28502 28495 -7
- Misses 15828 15835 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
No crash on 12.6 even without the patch. I will have to upgrade to 13 first. This is going to take a while. |
|
Yah it only crashes on 13 |
|
I cannot even reproduce it on Ventura. |
|
But it doesn't do any harm either, so ship it. |
This was referenced Oct 29, 2022
Merged
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects macOS 13+ due to the use of nullptr when initializing std::string.
Screenshots
Testing strategy
Tested by forcing the use of TouchID code, still needs to be tested in a signed build to ensure all code paths are clean.
Type of change