Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting existing socket file before making a new symbolic link #8656

Merged

Conversation

varjolintu
Copy link
Member

Removes the old socket before making a new symbolic link. Qt's function does not force it, and it does nothing if the target file already exists. Introduced in #8030.

Fixes #8634.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added the pr: backport pending Pull request yet to be backported to a previous release label Oct 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (422fd91) to head (998974c).
Report is 349 commits behind head on develop.

Files with missing lines Patch % Lines
src/browser/BrowserShared.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8656      +/-   ##
===========================================
- Coverage    64.30%   64.28%   -0.01%     
===========================================
  Files          341      341              
  Lines        44330    44331       +1     
===========================================
- Hits         28502    28496       -6     
- Misses       15828    15835       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey merged commit 69f05d4 into keepassxreboot:develop Oct 28, 2022
@varjolintu varjolintu deleted the fix/delete_socket_before_link branch October 28, 2022 11:37
@droidmonkey droidmonkey mentioned this pull request Oct 29, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 29, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Browser pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrade to 2.7.3 on Linux, cannot connect to browser
4 participants