Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent expired entries search if no results returned #8643

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

droidmonkey
Copy link
Member

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added bug pr: backport pending Pull request yet to be backported to a previous release labels Oct 25, 2022
@droidmonkey droidmonkey added this to the v2.7.4 milestone Oct 25, 2022
@droidmonkey droidmonkey requested a review from phoerious October 25, 2022 03:47
@michaelk83
Copy link

If the user initiates a search manually (doesn't matter where from), I think they'd expect to see something, even if the results are empty. I'm not entirely clear if this PR takes that into account or not.

But anyway, the real fix for #8626 would be to finish #7791 . @droidmonkey , how about including that in 2.7.4?

@droidmonkey
Copy link
Member Author

droidmonkey commented Oct 25, 2022

The code introduced here only ends the search if no entries are found when the "next search label" variable is set. This variable is only set when performing the expired entries on unlock search. Although it looks like the gui tests are failing on search.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (37baa6f) to head (26973fe).
Report is 343 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8643      +/-   ##
===========================================
+ Coverage    64.41%   64.42%   +0.01%     
===========================================
  Files          341      341              
  Lines        44242    44245       +3     
===========================================
+ Hits         28496    28504       +8     
+ Misses       15746    15741       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

* Fixes #8626
* Also remove old feature to set the title of a new entry to the current search text. This only made sense before advanced searching was made available.
@droidmonkey droidmonkey merged commit ceb2cd2 into develop Oct 29, 2022
@droidmonkey droidmonkey deleted the fix/expired-search branch October 29, 2022 13:31
@droidmonkey droidmonkey mentioned this pull request Oct 29, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 29, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A search string is set automatically after database unlock
4 participants