Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide usernames in preview panel when hidden in entry view #8608

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

droidmonkey
Copy link
Member

Screenshots

image

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added ux pr: backport pending Pull request yet to be backported to a previous release labels Oct 18, 2022
@droidmonkey droidmonkey added this to the v2.7.2 milestone Oct 18, 2022
@droidmonkey droidmonkey requested a review from phoerious October 18, 2022 23:00
@codecov-commenter
Copy link

Codecov Report

Base: 64.27% // Head: 64.25% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (b9e9a73) compared to base (1af985f).
Patch coverage: 73.91% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8608      +/-   ##
===========================================
- Coverage    64.27%   64.25%   -0.02%     
===========================================
  Files          341      341              
  Lines        44302    44323      +21     
===========================================
+ Hits         28471    28477       +6     
- Misses       15831    15846      +15     
Impacted Files Coverage Δ
src/gui/EntryPreviewWidget.cpp 84.60% <73.91%> (-0.47%) ⬇️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 56.06% <0.00%> (-3.03%) ⬇️
src/fdosecrets/dbus/DBusMgr.cpp 52.20% <0.00%> (-1.47%) ⬇️
src/core/FileWatcher.cpp 86.75% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@phoerious phoerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the GUI_HideUsernames option in 2.8 and simply go with the two toggles from the view menu for everything.

@droidmonkey droidmonkey merged commit e6b2e4e into develop Oct 19, 2022
@droidmonkey droidmonkey deleted the fix/hide-username-preview branch October 19, 2022 11:02
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username in detail pane shown while hide username is active
3 participants