Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newlines when copying from DatabaseWidget #8542

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

supershoop
Copy link
Contributor

Fixes #8469
Newlines are no longer replaced with paragraph separators when copying notes from DatabaseWidget.

Testing strategy

Tested in Windows 11 using WSL

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

Love the simplicity

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Base: 64.39% // Head: 64.38% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8356b18) compared to base (b1e7c34).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8542      +/-   ##
===========================================
- Coverage    64.39%   64.38%   -0.01%     
===========================================
  Files          339      339              
  Lines        44007    44007              
===========================================
- Hits         28334    28330       -4     
- Misses       15673    15677       +4     
Impacted Files Coverage Δ
src/gui/DatabaseWidget.cpp 61.16% <0.00%> (ø)
src/gui/Clipboard.cpp 78.95% <0.00%> (-7.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@supershoop supershoop deleted the branch keepassxreboot:develop October 5, 2022 01:26
@supershoop supershoop closed this Oct 5, 2022
@supershoop supershoop deleted the develop branch October 5, 2022 01:26
@supershoop supershoop restored the develop branch October 5, 2022 01:26
@supershoop supershoop reopened this Oct 5, 2022
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Oct 5, 2022
@droidmonkey droidmonkey merged commit 893b398 into keepassxreboot:develop Oct 5, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newlines missing when copy + pasting notes text
4 participants