Fix crash when application is unfocused during saves #8520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
PRE-RELEASE BUG
crash 💥
pr: backport pending
Codecov ReportBase: 64.41% // Head: 64.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #8520 +/- ##
===========================================
+ Coverage 64.41% 64.44% +0.03%
===========================================
Files 339 339
Lines 43953 43957 +4
===========================================
+ Hits 28309 28326 +17
+ Misses 15644 15631 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* Fix focus issues with new PasswordWidget * Fix focus wrapping when DatabaseTabWidget is not showing the tab bar * Fix focus wrapping in EditWidget views to move between category list and contents. This is not a perfect fix, but Qt has a mind of its own with these complex widgets. This will be fixed in future Ui improvements that move away from the category widget.
phoerious
approved these changes
Oct 13, 2022
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Fix Focus Traps!
Screenshots
Testing strategy
Type of change