Enable dark title bar on windows when accent color is not used #8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
user interface
platform: Windows
pr: backport pending
droidmonkey
force-pushed
the
hotfix/windows-titlebar
branch
from
fcf61db to
7e4db3f
Compare
Codecov ReportBase: 64.41% // Head: 64.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #8498 +/- ##
========================================
Coverage 64.41% 64.41%
========================================
Files 339 339
Lines 43953 43953
========================================
+ Hits 28309 28310 +1
+ Misses 15644 15643 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I honestly hate the black titlebar. 😒 |
|
You can always just delete the qt.conf file in your installation 😉 I am going to merge this for the sake of the discussion, also enabling the accent color in title bars ignores this feature anyway. |
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Testing strategy
Tested on Windows 11
Type of change