Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode detection on Linux/GNOME #8477

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Fix dark mode detection on Linux/GNOME #8477

merged 1 commit into from
Oct 2, 2022

Conversation

felipdsa21
Copy link
Contributor

The current implementation does not read the color-scheme setting at startup

Fixes #7817

Testing strategy

Changes were tested by setting the theme using GNOME Control Center and opening KPXC to determine if used the chosen theme

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (d181f80) to head (bc20982).
Report is 381 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/osutils/nixutils/NixUtils.cpp 42.86% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8477      +/-   ##
===========================================
+ Coverage    64.41%   64.44%   +0.03%     
===========================================
  Files          339      339              
  Lines        43963    43974      +11     
===========================================
+ Hits         28316    28338      +22     
+ Misses       15647    15636      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey added bug theme pr: backport pending Pull request yet to be backported to a previous release labels Oct 2, 2022
@droidmonkey droidmonkey added this to the v2.7.2 milestone Oct 2, 2022
@droidmonkey droidmonkey merged commit e7fe3ff into keepassxreboot:develop Oct 2, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 5, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeePassXC cannot detect the Gnome Theme
4 participants