Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for write permission before entering portable mode #8447

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested on Windows with a portable build from this branch and setting only read/list permissions on the directory.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added bug pr: backport pending Pull request yet to be backported to a previous release labels Sep 7, 2022
@droidmonkey droidmonkey added this to the v2.7.2 milestone Sep 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.66%. Comparing base (bdeef63) to head (203f6a1).
Report is 396 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8447      +/-   ##
===========================================
+ Coverage    64.64%   64.66%   +0.03%     
===========================================
  Files          338      338              
  Lines        43614    43615       +1     
===========================================
+ Hits         28190    28203      +13     
+ Misses       15424    15412      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey merged commit 61f9221 into develop Sep 7, 2022
@droidmonkey droidmonkey deleted the fix/portable-check branch September 7, 2022 11:06
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Sep 11, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for directory write permissions prior to entering portable mode
3 participants