Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gui feature to copy password with TOTP appended #8443

Merged

Conversation

jimheden
Copy link
Contributor

@jimheden jimheden commented Sep 6, 2022

For use cases where a single field is used to enter both password and TOTP, this would save time.

Testing strategy

Tested manually on Fedora 36

Type of change

  • ✅ New feature (change that adds functionality)

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #8443 (03e18c2) into develop (dd15db7) will increase coverage by 0.08%.
The diff coverage is 10.71%.

❗ Current head 03e18c2 differs from pull request most recent head b8b218e. Consider uploading reports for the commit b8b218e to get more accurate results

@@             Coverage Diff             @@
##           develop    #8443      +/-   ##
===========================================
+ Coverage    64.44%   64.52%   +0.08%     
===========================================
  Files          339      339              
  Lines        43954    43883      -71     
===========================================
- Hits         28325    28315      -10     
+ Misses       15629    15568      -61     
Impacted Files Coverage Δ
src/gui/DatabaseWidget.cpp 60.37% <0.00%> (-0.99%) ⬇️
src/gui/MainWindow.cpp 71.43% <100.00%> (+0.06%) ⬆️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 56.06% <0.00%> (-3.03%) ⬇️
src/fdosecrets/dbus/DBusMgr.cpp 52.20% <0.00%> (-1.47%) ⬇️
src/core/Entry.cpp 82.55% <0.00%> (-0.20%) ⬇️
src/gui/DatabaseTabWidget.cpp 64.38% <0.00%> (-0.08%) ⬇️
src/browser/BrowserService.h 100.00% <0.00%> (ø)
src/browser/BrowserAccessControlDialog.cpp 0.00% <0.00%> (ø)
src/browser/BrowserAction.cpp 9.18% <0.00%> (+0.21%) ⬆️
src/core/FileWatcher.cpp 86.75% <0.00%> (+1.20%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@droidmonkey
Copy link
Member

droidmonkey commented Sep 6, 2022

Can you list more than one website that forces this craziness? I am not a fan of adding this as a feature, it's undiscoverable and used by 0.01%. In the past we recommened you create an Auto-Type window association for this pattern: {PASSWORD}{TOTP}

@jimheden
Copy link
Contributor Author

jimheden commented Sep 6, 2022

I searched for "concatenate your password" and the first two links were sap and ibm, so perhaps useless for most, but quite useful for people who have to use {PASSWORD}{TOTP}

@jimheden
Copy link
Contributor Author

jimheden commented Sep 7, 2022

In my environment it's freeipa, and the clipboard is better than Auto-Type for me as I can share it with VMs.
https://www.freeipa.org/page/V4/OTP#Self-Managed_Tokens

@mpas97
Copy link
Contributor

mpas97 commented Sep 9, 2022

I've also worked in companies where this was treated as an essential security measure to use topt after password only. Even Apple has created a password manager resources repository recently where there is a main point "Websites Where 2FA Code is Appended to Password".

@droidmonkey droidmonkey force-pushed the feature/copy-password-and-otp branch from 03e18c2 to b8b218e Compare September 11, 2022 13:05
@droidmonkey droidmonkey added this to the v2.7.2 milestone Sep 11, 2022
@droidmonkey droidmonkey merged commit 33d8b6d into keepassxreboot:develop Sep 11, 2022
@jimheden jimheden deleted the feature/copy-password-and-otp branch September 14, 2022 20:42
@droidmonkey droidmonkey added pr: backport pending Pull request yet to be backported to a previous release pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 5, 2022
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: TOTP pr: backported Pull request backported to previous release pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants