Fix OPVault import when there are multiple OTP fields #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
bug
import: 1Password
pr: backport pending
Codecov Report
@@ Coverage Diff @@
## develop #8436 +/- ##
========================================
Coverage 64.45% 64.45%
========================================
Files 339 339
Lines 43763 43771 +8
========================================
+ Hits 28205 28211 +6
- Misses 15558 15560 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
droidmonkey
force-pushed
the
hotfix/opvault-totp
branch
from
969af41 to
15ae687
Compare
* Fix #8371 - store multiple OTP fields as `otp_#` instead of silently discarding them.
droidmonkey
force-pushed
the
hotfix/opvault-totp
branch
from
15ae687 to
735b245
Compare
phoerious
approved these changes
Sep 7, 2022
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otp_#instead of silently discarding them.Testing strategy
Added test case
Type of change