Enhance Tags / Saved Searches

[droidmonkey]

Enhance Tags UX

• Rename "Database Tags" to "Searches and Tags"
• Separate searching for all entries and resetting the search
• Support selecting multiple tags to search against
• Fix using escaped quotes in search terms
• Make tag searching more precise
• Support is:expired-# to search for entries expiring within # days. Exclude recycled entries from expired search.
• Don't list tags from entries that are recycled
• Force hide tag auto-completion menu when tag editing widget is hidden. On rare occasions the focus out signal is not called when the tag view is hidden (entry edit is closed), this resolves that problem.
• Remove spaces from before and after tags to prevent seemingly duplicate tags from being created.
• Also fix some awkward signal/slot dances that were setup over time with the entry view and preview widget.

Add search saving and recall

• Add ability to save searches and recall them from the "Searches and Tags" view
• Add ability to remove a tag from all entries from the "Searches and Tags" view
• Cleanup tag handling and widgets

Allow changing tags for multiple entries through context menu

• Closes Set and unset tags from several entries at once #8277 - show context menu with currently available tags in database and checks those that are set on one or more selected entries. When a tag is selected it is either set or unset on all entries depending on its checked state.

Other Improvements

• Fix Column sorting is not saved after showing expired entries  #8036 - use search interface to display expiring entries on first unlock.
• Fix Tab navigation doesn't respect removed panels by the user #8352 - Correctly adjust for missing panels when tabbing around the Database Widget
• Closes View count of entries in each Group #3963 - Show current entry count in status bar
• Improve various icons in context menus

Screenshots

Save Searches!

Remove Searches and Tags!

New icons!

Testing strategy

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)
• ✅ New feature (change that adds functionality)

[droidmonkey]

note: looks like I need to fix the entry count display on unlock again...

[michaelk83]

"Reset View" is unclear. Maybe "Reset Search"? What does this do, and how is it different from "All Entries"?

Support is:expired-# to search for entries expiring within # days.

There are a few other bits in #7791 that are related to this. Though some of it can wait for a separate PR, I guess.

[michaelk83]

"Reset View" is unclear. Maybe "Reset Search"? What does this do, and how is it different from "All Entries"?

Found it:

m_presetTags << qMakePair(QString(""), tr("Reset View")) << qMakePair(QString("*"), tr("All Entries"))

Hmm.. "Reset Search" somewhat makes sense here, but how about "All (global)" and "All (current view)"?

[droidmonkey]

"Clear Search" would make sense as well.

I will untag the expired entry view issue since it's a multiparter

[droidmonkey]

@michaelk83 I went a little crazy and added a bunch of fun stuff, check it out again

[michaelk83]

(sorry for the delay)

I don't see the "Expiring in 3 days" and "Multiple tags" in the code. Are those just searches you've saved manually? The other 4 are enough by default, I think.

"Expiring in 3 days" and "Expired" will end up the same thing once #7791 is done.

The rest LGTM, though I haven't looked at the code much. I like the new "Searches and Tags" header and the little save button. Will need to update the docs for the new features.

[droidmonkey]

Yes, expiring in 3 days is a saved search

[jamilraichouni]

Not important but worth mentioning:
When using the macos GUI in English it states 2 Entry(s) for instance. But it must be x Entries if x > 1.
So in the case of the english word Entry you cannot cover singular and plural by appending the suffix (s). That works for User -> User(s) and many other english words but not in the given case or for 1 Baby and x Babies etc.

Moved my comment to #3963 (comment)