Support numeric aware sorting on Windows and macOS #8363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
user interface
pr: backport pending
Codecov Report
@@ Coverage Diff @@
## develop #8363 +/- ##
===========================================
- Coverage 64.67% 64.43% -0.24%
===========================================
Files 338 339 +1
Lines 43623 43740 +117
===========================================
- Hits 28212 28182 -30
- Misses 15411 15558 +147
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
phoerious
reviewed
Aug 29, 2022
|
Nevermind, despite the documentation it is absolutely worthless, unless we use icu on Linux. https://code.woboq.org/qt5/qtbase/src/corelib/text/qcollator_posix.cpp.html#58 |
|
You would still get rid of the Windows and macOS boilerplate code. |
|
Yah sorry I meant to come back to this one. |
* Fix #8356 - Qt does not enable numeric aware sorting when using locale sort. Extracted both Windows and macOS locale aware sorting code and added the appropriate numeric aware flag. Note: There is no std library way to do this so Linux is out of luck for now.
droidmonkey
force-pushed
the
hotfix/numeric-sort
branch
from
6d2f407 to
c189573
Compare
|
ready for you |
phoerious
approved these changes
Sep 7, 2022
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There is no std library way to do this so Linux is out of luck for now.
Screenshots
Testing strategy
Tested and mac and windows
Type of change