Fix Windows Hello bugs #8354
Merged
Fix Windows Hello bugs #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
platform: Windows
crash 💥
feature: QuickUnlock
pr: backport pending
Codecov Report
@@ Coverage Diff @@
## develop #8354 +/- ##
===========================================
- Coverage 64.49% 64.47% -0.01%
===========================================
Files 339 339
Lines 43763 43764 +1
===========================================
- Hits 28221 28216 -5
- Misses 15542 15548 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
phoerious
approved these changes
Aug 29, 2022
* Fix #7977 - wrap key signing request in try/catch block to prevent crashes on some machines. * Fix #8120 - try 3 times to bring Windows Hello prompt to front. This may be necessary on older machines that are slow to bring up the prompt window. Also remove defunct code on macOS to prevent window focus issues.
droidmonkey
force-pushed
the
hotfix/windows-hello
branch
from
5dbe66c to
fab58e7
Compare
droidmonkey
added
pr: backported
|
To those new people who have problem with a missing windows hello prompt on KeePassXC is probably because you might have installed the Legacy version just like I did. To fix this problem simply uninstall the Legacy version and install the regular installer marked on the image down below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove defunct code on macOS to prevent window focus issues.
Testing strategy
Tested on Windows and macOS
Type of change