Hardware keys: Add VivoKey and DT token ATRs #8332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ATRs of the VivoKey Apex and the Dangerous Things FlexSecure tokens, in order to display a human-readable name instead of "Unknown Key".
Codecov Report
@@ Coverage Diff @@
## develop #8332 +/- ##
===========================================
- Coverage 64.45% 64.42% -0.03%
===========================================
Files 339 339
Lines 43732 43732
===========================================
- Hits 28186 28173 -13
- Misses 15546 15559 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Sweet! |
droidmonkey
approved these changes
Aug 4, 2022
droidmonkey
added
feature: Hardware Keys
pr: backport pending
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ATRs of the VivoKey Apex and the Dangerous Things FlexSecure tokens, in order to display a human-readable name instead of "Unknown Key". It is a small change adding two entries to a string map. These tokens are NFC-only.
As projected in #6895 (#6766), more hardware tokens than the YubiKey implement the Yubico-style HMAC-SHA1 protocol.
Testing strategy
Compiled on Linux and tested with the mentioned tokens.
Type of change