TouchID support refactoring #8311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix keepassxreboot#7695: TouchID and Apple Watch support is now detected both at compile time and runtime
Codecov Report
@@ Coverage Diff @@
## develop #8311 +/- ##
===========================================
+ Coverage 64.45% 64.48% +0.03%
===========================================
Files 339 339
Lines 43709 43709
===========================================
+ Hits 28172 28184 +12
+ Misses 15537 15525 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Each authentication method can become unavailable during runtime: user can close the laptop lid or take off the watch. This also means that we probably have to add some sort of timer to the DatabaseOpenWidget to check the unlock method periodically in case if quick unlock is enabled and a previously unavailable authentication method becomes available again.
michaelk83
reviewed
Aug 3, 2022
- Password data removal - TODOs and descriptions for some functions
yowidin
force-pushed
the
fix/7695-quick-unlock-with-apple-watch
branch
from
73a63d4 to
e552c11
Compare
droidmonkey
added
platform: macOS
feature: QuickUnlock
pr: backport pending
droidmonkey
approved these changes
Sep 5, 2022
pull bot
pushed a commit
to annihilatorrrr/keepassxc
that referenced
this pull request
Sep 5, 2022
Fixes keepassxreboot#7695 - Properly set compile flags based on availability of watch unlock in the API.
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Sep 5, 2022
Fixes keepassxreboot#7695 - Properly set compile flags based on availability of watch unlock in the API.
droidmonkey
added
pr: backported
droidmonkey
pushed a commit
that referenced
this pull request
Sep 11, 2022
Fixes #7695 - Properly set compile flags based on availability of watch unlock in the API.
droidmonkey
pushed a commit
that referenced
this pull request
Sep 22, 2022
Fixes #7695 - Properly set compile flags based on availability of watch unlock in the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TouchID and Apple Watch support is now detected both at compile time and runtime.
We need both runtime and compile time checks to solve the following problems:
Should fix #7695:
Testing strategy
Type of change