Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI output when using clip with the -t flag #8271

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

andreas-ementio
Copy link
Contributor

if you use the CLI with -t/--totp flag, the program prints out: "Entry's "password" attribute copied to the clipboard!"
expected output is "Entry's "totp" attribute copied to the clipboard!" the same when you run with -a totp

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #8271 (847727d) into develop (dab6d94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 847727d differs from pull request most recent head 157885f. Consider uploading reports for the commit 157885f to get more accurate results

@@           Coverage Diff            @@
##           develop    #8271   +/-   ##
========================================
  Coverage    64.45%   64.46%           
========================================
  Files          339      339           
  Lines        43709    43710    +1     
========================================
+ Hits         28172    28174    +2     
+ Misses       15537    15536    -1     
Impacted Files Coverage Δ
src/cli/Clip.cpp 95.05% <100.00%> (+0.05%) ⬆️
src/core/FileWatcher.cpp 86.75% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab6d94...157885f. Read the comment docs.

@louib
Copy link
Member

louib commented Jul 17, 2022

@andreas-ementio good catch!
Could you update the testClip unit test at the same time? See here for an example.

if you use the CLI with -t/--totp flag, the program prints out: "Entry's "password" attribute copied to the clipboard!"
expected output is "Entry's "totp" attribute copied to the clipboard!" the same when you run with -a totp
@droidmonkey droidmonkey added this to the v2.7.2 milestone Jul 24, 2022
@droidmonkey droidmonkey added the pr: backport pending Pull request yet to be backported to a previous release label Jul 24, 2022
@droidmonkey droidmonkey requested review from droidmonkey and louib July 24, 2022 03:23
@droidmonkey droidmonkey merged commit 612c109 into keepassxreboot:develop Sep 8, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Sep 11, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: CLI pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants