[CLI] Add Option to show all attributes (Show command) #8256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8256 +/- ##
===========================================
+ Coverage 64.43% 64.45% +0.02%
===========================================
Files 339 339
Lines 43749 43763 +14
===========================================
+ Hits 28188 28204 +16
+ Misses 15561 15559 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
droidmonkey
approved these changes
Jul 9, 2022
|
@droidmonkey pretty sure the failure is a flaky test. I'll have to rebase after you merge #8241 anyway, so I won't bother for now. |
|
Translations need to be updated |
droidmonkey
added
pr: backport pending
droidmonkey
approved these changes
Aug 20, 2022
louib
force-pushed
the
cli_show_all
branch
3 times, most recently
from
5506a2e to
28adb8e
Compare
Is that on transifex? I don't remember ever having to do that for new strings 🤔 |
|
You have to run |
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Aug 21, 2022
…t#8256) * Adding --all option to Show
pull bot
pushed a commit
to annihilatorrrr/keepassxc
that referenced
this pull request
Aug 21, 2022
…t#8256) * Adding --all option to Show
t-h-e
pushed a commit
to t-h-e/keepassxc
that referenced
this pull request
Sep 8, 2022
…t#8256) * Adding --all option to Show
droidmonkey
added
pr: backported
droidmonkey
pushed a commit
that referenced
this pull request
Sep 11, 2022
* Adding --all option to Show
droidmonkey
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Adding --all option to Show
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8243
I renamed the
showDefaultAttributesvariable toattributesWereSpecifiedto make it more explicit what the variable is used for.Testing strategy
Unit tests
Type of change