Adding top-level fields to CLI show and clip commands #8241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louib
changed the title
|
Note that one consequence of the current implementation is that it won't be possible anymore to select an attribute from the CLI if it has the same name as a top-level field. I feel like this is a fair limitation. Also, we might consider removing the braces around the UUID. I'm not even sure why they are there in the first place. |
Codecov Report
@@ Coverage Diff @@
## develop #8241 +/- ##
===========================================
- Coverage 64.45% 64.44% -0.01%
===========================================
Files 339 339
Lines 43732 43749 +17
===========================================
+ Hits 28186 28191 +5
- Misses 15546 15558 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
droidmonkey
requested changes
Jul 7, 2022
droidmonkey
approved these changes
Jul 7, 2022
|
Need to fix code format then can merge |
|
@droidmonkey ready to merge, when/if the mac tests ever finish. |
louib
force-pushed
the
cli_show_uuid
branch
4 times, most recently
from
89d562e to
73a6faa
Compare
The top-level fields are currently not accessible from the CLI, which makes it impossible to select entries or groups based on the UUID. There are other top-level fields I believe, like the expiry date, but I only added the two most critical fields for the moment.
droidmonkey
added
the
pr: backport pending
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4112
Preparation work for #4113 and #3720
The top-level fields are currently not accessible from the CLI, which
makes it impossible to select entries or groups based on the UUID.
There are other top-level fields I believe, like the expiry date, but
I only added the two most critical fields for now. I also considered
defining the constants in
Entryinstead ofEntryAttributes, becausethey are not attributes per se. I'm not sure which choice is better tbh.
Testing strategy
Updated the unit tests.
Type of change