Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of "Lock on Minimize" setting #8202

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested on Windows

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added the ux label Jun 28, 2022
@droidmonkey droidmonkey added this to the v2.7.2 milestone Jun 28, 2022
@droidmonkey droidmonkey requested a review from phoerious June 28, 2022 03:22
@droidmonkey droidmonkey added the pr: backport pending Pull request yet to be backported to a previous release label Jun 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Attention: Patch coverage is 38.23529% with 21 lines in your changes missing coverage. Please review.

Project coverage is 64.42%. Comparing base (861fe2e) to head (aa70a66).
Report is 388 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/DatabaseTabWidget.cpp 20.00% 8 Missing ⚠️
src/gui/ApplicationSettingsWidget.cpp 40.00% 6 Missing ⚠️
src/gui/Clipboard.cpp 58.33% 5 Missing ⚠️
src/gui/MainWindow.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8202      +/-   ##
===========================================
- Coverage    64.45%   64.42%   -0.03%     
===========================================
  Files          339      339              
  Lines        43699    43722      +23     
===========================================
+ Hits         28162    28164       +2     
- Misses       15537    15558      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Fix #1090 - delay locking databases after minimize to allow for clipboard use, Auto-Type use, and browser integration use.

* Fix #6757 - prevent setting both minimize on unlock and lock on minimize settings at the same time.
@droidmonkey droidmonkey merged commit a6d3f97 into develop Aug 1, 2022
@droidmonkey droidmonkey deleted the fix/lock-minimize branch August 1, 2022 22:19
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release ux
Projects
None yet
3 participants