Fix crash when deleting items in recycle bin while searching #8117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix #8099 * Clean up code that connects groups to the entry view. Instead of connecting ALL groups from ALL databases, we only need to connect the groups that entries actually belong to. This solves the bug and also reduces overhead.
droidmonkey
added
crash 💥
pr: backport pending
Codecov ReportBase: 64.41% // Head: 64.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #8117 +/- ##
========================================
Coverage 64.41% 64.41%
========================================
Files 339 339
Lines 43963 43953 -10
========================================
- Hits 28316 28310 -6
+ Misses 15647 15643 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phoerious
approved these changes
Sep 22, 2022
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Sep 22, 2022
…xreboot#8117) * Fix keepassxreboot#8099 * Clean up code that connects groups to the entry view. Instead of connecting ALL groups from ALL databases, we only need to connect the groups that entries actually belong to. This solves the bug and also reduces overhead.
pull bot
pushed a commit
to annihilatorrrr/keepassxc
that referenced
this pull request
Sep 22, 2022
…xreboot#8117) * Fix keepassxreboot#8099 * Clean up code that connects groups to the entry view. Instead of connecting ALL groups from ALL databases, we only need to connect the groups that entries actually belong to. This solves the bug and also reduces overhead.
droidmonkey
added a commit
that referenced
this pull request
Sep 23, 2022
* Fix #8099 * Clean up code that connects groups to the entry view. Instead of connecting ALL groups from ALL databases, we only need to connect the groups that entries actually belong to. This solves the bug and also reduces overhead.
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested that this fixes the bug and causes no regressions.
Type of change