FdoSecrets: only show unlock dialog when there is no unlocked & exposed database #8028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aetf
force-pushed
the
feature/fdo-secrets-unlock-once
branch
from
cb3891d to
d1e512e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #8028 +/- ##
===========================================
+ Coverage 64.37% 64.46% +0.09%
===========================================
Files 339 339
Lines 43576 43610 +34
===========================================
+ Hits 28048 28109 +61
+ Misses 15528 15501 -27
Continue to review full report at Codecov.
|
droidmonkey
added
the
pr: backport pending
droidmonkey
approved these changes
Jun 4, 2022
This commit implements the following logic: * If there're already unlocked collections, just use those, * otherwise, show the unlock dialog until there's an unlocked and exposed collection. * Fixes keepassxreboot#7574
droidmonkey
force-pushed
the
feature/fdo-secrets-unlock-once
branch
from
d1e512e to
7697309
Compare
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is:
Fix #7574
This currently is based on #8022 because both touch the service unlock code. I'll rebase once that one is merged.
Testing strategy
Added unit test.
Type of change