Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FdoSecrets: ask to unlock the database before storing entries #8022

Merged

Conversation

Aetf
Copy link
Contributor

@Aetf Aetf commented May 7, 2022

Fix #7989.

As creating items in the spec can return a proper prompt object, we can implement this without the blocking hack used in "unlock before searching". So this is enabled unconditionally.

Testing strategy

Added unit test

Type of change

  • ✅ New feature (change that adds functionality)

@Aetf Aetf requested a review from droidmonkey May 7, 2022 06:00
@Aetf Aetf force-pushed the feature/fdo-secrets-unlock-create branch 2 times, most recently from 5d76ee5 to 94bdf7d Compare May 9, 2022 04:56
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #8022 (5d0879e) into develop (c5467c4) will increase coverage by 0.02%.
The diff coverage is 77.03%.

@@             Coverage Diff             @@
##           develop    #8022      +/-   ##
===========================================
+ Coverage    64.35%   64.36%   +0.02%     
===========================================
  Files          339      339              
  Lines        43535    43576      +41     
===========================================
+ Hits         28014    28047      +33     
- Misses       15521    15529       +8     
Impacted Files Coverage Δ
src/fdosecrets/objects/Prompt.h 81.25% <ø> (-6.25%) ⬇️
src/fdosecrets/objects/Service.h 100.00% <ø> (ø)
src/fdosecrets/objects/Prompt.cpp 81.85% <75.47%> (-0.21%) ⬇️
src/fdosecrets/objects/Service.cpp 83.06% <80.95%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5467c4...5d0879e. Read the comment docs.

@droidmonkey droidmonkey added this to the v2.7.2 milestone May 28, 2022
@droidmonkey droidmonkey added the pr: backport pending Pull request yet to be backported to a previous release label May 28, 2022
Also only emit databaseUnlockFinished after the database is unlocked

Fix keepassxreboot#7989
@droidmonkey droidmonkey force-pushed the feature/fdo-secrets-unlock-create branch from 94bdf7d to 5d0879e Compare June 4, 2022 19:22
@droidmonkey droidmonkey merged commit e2bf537 into keepassxreboot:develop Jun 4, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Jun 27, 2022
@Aetf Aetf deleted the feature/fdo-secrets-unlock-create branch December 5, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Secret Service pr: backported Pull request backported to previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret Service: Storing a secret does not trigger unlock
3 participants