Browser feature: Add omit WWW subdomain group option #7988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7988 +/- ##
===========================================
+ Coverage 64.40% 64.47% +0.07%
===========================================
Files 339 339
Lines 43682 43696 +14
===========================================
+ Hits 28131 28170 +39
+ Misses 15551 15526 -25 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
varjolintu
force-pushed
the
feature/browser_omit_www_subdomain
branch
from
8d3509b to
9b0cbbb
Compare
droidmonkey
added
the
pr: backport pending
droidmonkey
requested changes
Jun 4, 2022
|
I want to test this with the browser but the code looks good! |
droidmonkey
force-pushed
the
feature/browser_omit_www_subdomain
branch
from
f8cae7d to
7a6a3c9
Compare
|
Thankfully we have robust tests cause you made a couple copy/paste errors in the sortPriority function! All fixed now. |
droidmonkey
approved these changes
Jun 12, 2022
|
@droidmonkey Oops. Thanks! |
droidmonkey
added
pr: backported
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new group option "Omit WWW subdomain from matching" that ignores the common subdomain from all entries during matching.
This option is also useful when importing credentials from other password managers.
Testing strategy
Manually + automatic tests added.
Type of change