Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autotype menu entries on Windows #7987

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Fix autotype menu entries on Windows #7987

merged 1 commit into from
Jun 6, 2022

Conversation

mgziminsky
Copy link
Contributor

The addition of the "Use Virtual Keyboard" menu entry from commit 8a7eb36 on Windows broke the enabling/disabling of the "Copy *" autotype menu entries due to incorrect hard-coded indices. Fixed by replacing the indexing with a custom property on each action to identify when it should be enabled/disabled.

Testing strategy

On Windows, confirmed that the correct menu entries are enabled/disabled for the different combinations of username/password/totp.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #7987 (f0d010b) into develop (f15ee90) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #7987      +/-   ##
===========================================
- Coverage    64.29%   64.27%   -0.02%     
===========================================
  Files          339      339              
  Lines        43430    43444      +14     
===========================================
- Hits         27921    27920       -1     
- Misses       15509    15524      +15     
Impacted Files Coverage Δ
src/autotype/AutoTypeSelectDialog.cpp 0.00% <0.00%> (ø)
src/core/Entry.cpp 82.76% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15ee90...f0d010b. Read the comment docs.

@droidmonkey
Copy link
Member

Oof, good catch

@droidmonkey droidmonkey added this to the v2.7.2 milestone May 1, 2022
@droidmonkey droidmonkey self-requested a review May 1, 2022 10:18
@droidmonkey droidmonkey added the pr: backport pending Pull request yet to be backported to a previous release label May 1, 2022
@droidmonkey droidmonkey merged commit bc0a5a9 into keepassxreboot:develop Jun 6, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Jun 27, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Auto-Type pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants