Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize path (slashes to be precise) when opening a database or saving the last used database paths (Fixes #7821) #7864

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

HusseinKabbout
Copy link
Contributor

This PR fixes the funny behavior described in issue #7821.

To summarize, depending on how you load a database in Windows, you will find the path (to the database) twice in the Recent Databases menu entry. The only difference between the two entries would be the slashes.

Testing strategy

As I don't have a windows environment to test this small change, I don't really know how to test it for windows (because it is a windows only bug). So my question here is, how do you test your code for linux and windows?

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Copy link
Member

@phoerious phoerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think you need to add the explicit include to the other file as well, though. There are also some code formatting issues, but other than that, lgtm.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (5916a8f) to head (0e00699).
Report is 444 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/MainWindow.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7864      +/-   ##
===========================================
+ Coverage    64.31%   64.31%   +0.01%     
===========================================
  Files          339      339              
  Lines        43404    43430      +26     
===========================================
+ Hits         27911    27930      +19     
- Misses       15493    15500       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@phoerious phoerious merged commit 692c95b into keepassxreboot:develop Apr 12, 2022
@phoerious phoerious added the pr: backport pending Pull request yet to be backported to a previous release label Apr 12, 2022
droidmonkey pushed a commit that referenced this pull request Jun 27, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Jun 27, 2022
t-h-e pushed a commit to t-h-e/keepassxc that referenced this pull request Sep 8, 2022
droidmonkey pushed a commit that referenced this pull request Sep 22, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants