-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize path (slashes to be precise) when opening a database or saving the last used database paths (Fixes #7821) #7864
Conversation
…ing the last used database paths (#7821)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think you need to add the explicit include to the other file as well, though. There are also some code formatting issues, but other than that, lgtm.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7864 +/- ##
===========================================
+ Coverage 64.31% 64.31% +0.01%
===========================================
Files 339 339
Lines 43404 43430 +26
===========================================
+ Hits 27911 27930 +19
- Misses 15493 15500 +7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…ing the last used database paths (keepassxreboot#7864) Fixes keepassxreboot#7821
This PR fixes the funny behavior described in issue #7821.
To summarize, depending on how you load a database in Windows, you will find the path (to the database) twice in the
Recent Databases
menu entry. The only difference between the two entries would be the slashes.Testing strategy
As I don't have a windows environment to test this small change, I don't really know how to test it for windows (because it is a windows only bug). So my question here is, how do you test your code for linux and windows?
Type of change