-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thirdparty/ykcore: link against libpthread #7807
Merged
phoerious
merged 1 commit into
keepassxreboot:develop
from
Piraty:develop-fix-ykcore-pthread
Apr 15, 2022
Merged
thirdparty/ykcore: link against libpthread #7807
phoerious
merged 1 commit into
keepassxreboot:develop
from
Piraty:develop-fix-ykcore-pthread
Apr 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piraty
force-pushed
the
develop-fix-ykcore-pthread
branch
from
April 6, 2022 15:04
83bc756
to
c87a7f2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7807 +/- ##
===========================================
- Coverage 64.31% 64.29% -0.03%
===========================================
Files 339 339
Lines 43430 43430
===========================================
- Hits 27932 27919 -13
- Misses 15498 15511 +13
Continue to review full report at Codecov.
|
phoerious
requested changes
Apr 7, 2022
Piraty
force-pushed
the
develop-fix-ykcore-pthread
branch
2 times, most recently
from
April 12, 2022 22:46
9011b83
to
fdb66bf
Compare
phoerious
approved these changes
Apr 13, 2022
Could you rebase your branch to the latest develop HEAD, please? |
it was missing the -pthread flag ``` [382/549] Linking CXX executable src/keepassxc FAILED: src/keepassxc : && /usr/lib/ccache/bin/g++ -DNDEBUG -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -Og -ggdb3 -fdebug-prefix-map=/builddir/keepassxc-2.7.1=. -fno-common -Wall -Wextra -Wundef -Wpointer-arith -Wno-long-long -Wformat=2 -Wmissing-format-attribute -fvisibility=hidden -fvisibility-inlines-hidden -fstack-protector-strong -Wnon-virtual-dtor -Wold-style-cast -Woverloaded-virtual -Werror=format-security -Wcast-align -fsized-deallocation -Wno-deprecated-declarations -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,--no-add-needed -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro,-z,now -pie -Wl,--export-dynamic -rdynamic -fPIE -pie src/CMakeFiles/keepassxc.dir/keepassxc_autogen/mocs_compilation.cpp.o src/CMakeFiles/keepassxc.dir/main.cpp.o -o src/keepassxc src/libkeepassx_core.a src/libautotype.a src/browser/libkeepassxcbrowser.a src/qrcode/libqrcode.a /usr/lib/libQt5Svg.so.5.15.2 /usr/lib/libqrencode.so src/fdosecrets/libfdosecrets.a /usr/lib/libQt5Concurrent.so.5.15.2 /usr/lib64/libpcsclite.so src/libzxcvbn.a /usr/lib/libargon2.so src/thirdparty/ykcore/libykcore.a /usr/lib/libusb-1.0.so src/sshagent/libsshagent.a /usr/lib/libQt5Network.so.5.15.2 src/keeshare/libkeeshare.a /usr/lib/libQt5Widgets.so.5.15.2 /usr/lib/libbotan-2.so /usr/lib/libz.so /usr/lib/libminizip.so /usr/lib/libQt5DBus.so.5.15.2 /usr/lib/libQt5X11Extras.so.5.15.2 /usr/lib/libQt5Gui.so.5.15.2 /usr/lib/libQt5Core.so.5.15.2 -lX11 && : /usr/bin/ld: src/thirdparty/ykcore/libykcore.a(ykcore.c.o): undefined reference to symbol 'pthread_setspecific@@GLIBC_2.2.5' /usr/bin/ld: /lib64/libpthread.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ```
Piraty
force-pushed
the
develop-fix-ykcore-pthread
branch
from
April 13, 2022 08:01
fdb66bf
to
6abc55c
Compare
rebased |
phoerious
added
the
pr: backport pending
Pull request yet to be backported to a previous release
label
Apr 15, 2022
droidmonkey
pushed a commit
that referenced
this pull request
Jun 27, 2022
droidmonkey
added
pr: backported
Pull request backported to previous release
and removed
pr: backport pending
Pull request yet to be backported to a previous release
labels
Jun 27, 2022
t-h-e
pushed a commit
to t-h-e/keepassxc
that referenced
this pull request
Sep 8, 2022
droidmonkey
pushed a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keepassxc failed to link ykcore library due to missing
-pthread
flag.Build Log
Testing strategy
Build for Void Linux
Type of change