Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Entry Preview layout #7767

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Improve Entry Preview layout #7767

merged 1 commit into from
Apr 2, 2022

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Apr 2, 2022

Screenshots

BEFORE:
image

AFTER:
image

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added bug user interface pr: backport pending Pull request yet to be backported to a previous release labels Apr 2, 2022
@droidmonkey droidmonkey added this to the v2.7.1 milestone Apr 2, 2022
@droidmonkey droidmonkey requested a review from phoerious April 2, 2022 12:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (aca197a) to head (9aa606e).
Report is 461 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7767      +/-   ##
===========================================
- Coverage    64.31%   64.27%   -0.04%     
===========================================
  Files          339      339              
  Lines        43450    43450              
===========================================
- Hits         27943    27927      -16     
- Misses       15507    15523      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@michaelk83
Copy link

michaelk83 commented Apr 2, 2022

Maybe instead of moving the URL, move the tags list, and have it span both columns?
Or maybe like this:

Username  ....           Password  ....
     URL  ....         Expiration  ....
    Tags  [ ... ][ ... ][ ... ][ ... ][ ... ]
   Notes  +---------------------------------+
          |                                 |
          +---------------------------------+

This way, all "identifiers" are together on the left, password and expiry are together on the right, tags and notes both have plenty of room (span both columns).

Though a disadvantage of the latter is that it's harder to visually scan the Username/Password pair when they're not in the same column...

@droidmonkey
Copy link
Member Author

droidmonkey commented Apr 2, 2022

I tried a couple layouts, this one was the best given the current format. Having a lot of tags (or really wordy tags) on a single entry should be rare.

Although your idea and keeping url in upper right might be desirable. I can try that.

* Fix #7672 - notes preview spans the entire length of the preview pane again
* Fix #4242 - Allow selecting entry title text in preview
* Improve multi-line tag preview
* Fixup alignment and spacing of fields
@droidmonkey droidmonkey force-pushed the hotfix/preview-notes branch from 07ec015 to 9aa606e Compare April 2, 2022 15:53
@droidmonkey
Copy link
Member Author

droidmonkey commented Apr 2, 2022

@michaelk83 I used your suggestion and left URL in top right, it is much better thank you! Screenshot updated up top.

@droidmonkey droidmonkey merged commit dd52177 into develop Apr 2, 2022
@droidmonkey droidmonkey deleted the hotfix/preview-notes branch April 2, 2022 16:50
@phoerious phoerious mentioned this pull request Apr 4, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Apr 6, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - GUI, notes have limited margins Allow to copy Header of the Entry-Preview-Panel
4 participants