Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Agent: Fix Windows agent selection, radio buttons #7764

Merged

Conversation

hifi
Copy link
Member

@hifi hifi commented Apr 2, 2022

When we added support for having multiple agents enabled at the same time on Windows the unfortunate default was that no agents were enabled. This is really confusing.

Now Pageant is (again) the default and you can't create a combination that would have integration enabled but no agents.

Partially helps with #7473 but this also adds a new translation string, unfortunately.

Screenshots

image

Testing strategy

Quickly by hand that all positions of the radio selection were correctly saved to config file and that on first launch Pageant was selected.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@hifi hifi added bug feature: SSH agent pr: backport pending Pull request yet to be backported to a previous release labels Apr 2, 2022
@hifi hifi added this to the v2.7.1 milestone Apr 2, 2022
@hifi hifi force-pushed the fix/sshagent-windows-selection branch from 8ad6a30 to 560cd1a Compare April 2, 2022 04:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.29%. Comparing base (aca197a) to head (53d88df).
Report is 461 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7764      +/-   ##
===========================================
- Coverage    64.31%   64.29%   -0.02%     
===========================================
  Files          339      339              
  Lines        43450    43451       +1     
===========================================
- Hits         27943    27934       -9     
- Misses       15507    15517      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@hifi hifi force-pushed the fix/sshagent-windows-selection branch from 560cd1a to 53d88df Compare April 2, 2022 09:36
@droidmonkey droidmonkey merged commit 2b8d670 into keepassxreboot:develop Apr 2, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Apr 6, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: SSH agent pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants