Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 12 hours expiration preset #7738

Conversation

schlimmchen
Copy link
Contributor

This adds a 12 hours expiration preset to the list of expiration presets and renames the "Tomorrow" preset to "24 hours". Fixes #7369 (ignoring the request to allow custom presets, which would be covered by #4896).

Screenshots

image

Testing strategy

Manual, see screenshot.

Type of change

  • ✅ New feature (change that adds functionality)

@schlimmchen schlimmchen force-pushed the issue/7369-12-hours-expiration-preset branch from dbfb3ac to 84af3db Compare March 31, 2022 07:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.32%. Comparing base (044fc8d) to head (84af3db).
Report is 462 commits behind head on develop.

Files with missing lines Patch % Lines
src/core/TimeDelta.cpp 45.45% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7738      +/-   ##
===========================================
- Coverage    64.32%   64.32%   -0.00%     
===========================================
  Files          339      339              
  Lines        43442    43450       +8     
===========================================
+ Hits         27941    27945       +4     
- Misses       15501    15505       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 31, 2022
@droidmonkey droidmonkey merged commit aca197a into keepassxreboot:develop Mar 31, 2022
@schlimmchen schlimmchen deleted the issue/7369-12-hours-expiration-preset branch March 31, 2022 11:06
pull bot pushed a commit to nonomal/keepassxc that referenced this pull request Mar 31, 2022
* Add hours precision to TimeDelta

* Add 12 hours expiration preset

Fixes keepassxreboot#7369
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Apr 6, 2022
t-h-e pushed a commit to t-h-e/keepassxc that referenced this pull request Sep 8, 2022
* Add hours precision to TimeDelta

* Add 12 hours expiration preset

Fixes keepassxreboot#7369
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: new feature Pull request that adds a new feature user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hour options (4, 8, 12, 16) to password expiration presets
4 participants