Fix crash when building history changes, add tags to history compare, fix minizip-ng compiling #7638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
bug
crash 💥
pr: backport pending
droidmonkey
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7638 +/- ##
===========================================
- Coverage 64.30% 64.28% -0.03%
===========================================
Files 339 339
Lines 43448 43448
===========================================
- Hits 27938 27927 -11
- Misses 15510 15521 +11 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
phoerious
requested changes
Apr 2, 2022
* Replace rarely hit asserts with defined nullptr checks when replacing references without a group * Fix #7603 * Replace TOTP history comparison with checking the actual TOTP output instead of a compiled string
* minizip-ng has slightly different defines and function names than the original minizip. These changes adapt the existing code to use the minizip-ng versions if necessary.
droidmonkey
force-pushed
the
hotfix/totp-crash
branch
from
3c69542 to
9d0a937
Compare
phoerious
approved these changes
Apr 3, 2022
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when building history changes
Add tags to history comparison
Fix compiling with minizip-ng
Testing strategy
Tested minizip fixes on Fedora
Type of change