Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setChangeCurrentOnDrag property to handle drag and drop between tabs #7628

Merged

Conversation

daxcore
Copy link
Contributor

@daxcore daxcore commented Mar 23, 2022

drag and drop of entries between tabs doesn't work for wayland

the current implementation of DragTabBar is obsolete since Qt 5.4 with property changeCurrentOnDrag

.FIXES #7155

Testing strategy

Tested in self-compiled application. The feature still works now.

Type of change

  • ✅ Bug fix
  • ✅ Refactor

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@4178e72). Learn more about missing BASE report.
Report is 470 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7628   +/-   ##
==========================================
  Coverage           ?   64.31%           
==========================================
  Files              ?      339           
  Lines              ?    43423           
  Branches           ?        0           
==========================================
  Hits               ?    27926           
  Misses             ?    15497           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mahaase
Copy link

mahaase commented Mar 24, 2022

Need help. What's about this "Windows 10 (KeePassXC) — TeamCity build failed" problem. I don't understand this.

@droidmonkey
Copy link
Member

Just transient test failure, ignore it

@droidmonkey droidmonkey added bug user interface platform: Linux - Wayland pr: backport pending Pull request yet to be backported to a previous release labels Mar 28, 2022
@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 28, 2022
@droidmonkey
Copy link
Member

I need to test auto tab switching on windows and Mac with this change. Should be ok but I distrust Qt.

@droidmonkey droidmonkey merged commit 044fc8d into keepassxreboot:develop Mar 30, 2022
@daxcore daxcore deleted the bugfix/QTabBar4WaylandDev branch March 30, 2022 17:59
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Apr 6, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Linux - Wayland pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wayland][2.6.6] drag and drop among tabs no longer works
5 participants