Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce delay when searching entries in Auto-Type select dialog #7598

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested on Windows

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added feature: Auto-Type pr: backport pending Pull request yet to be backported to a previous release labels Mar 22, 2022
@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 22, 2022
@droidmonkey droidmonkey requested a review from hifi March 22, 2022 20:56
Copy link

@pauschuu pauschuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Built and tested on my system, works.

Copy link
Member

@hifi hifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue, need to make the delay a shared const as well.

src/autotype/AutoTypeSelectDialog.cpp Outdated Show resolved Hide resolved
@droidmonkey droidmonkey force-pushed the hotfix/autotype-delay branch from 4fda468 to 2fee61a Compare March 23, 2022 12:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #7598 (2fee61a) into develop (7dc2d23) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #7598      +/-   ##
===========================================
+ Coverage    64.24%   64.27%   +0.02%     
===========================================
  Files          340      340              
  Lines        43465    43468       +3     
===========================================
+ Hits         27923    27935      +12     
+ Misses       15542    15533       -9     
Impacted Files Coverage Δ
src/autotype/AutoTypeSelectDialog.cpp 0.00% <0.00%> (ø)
src/core/FileWatcher.cpp 86.75% <0.00%> (+1.20%) ⬆️
src/fdosecrets/dbus/DBusMgr.cpp 53.67% <0.00%> (+1.47%) ⬆️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 59.09% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc2d23...2fee61a. Read the comment docs.

Copy link
Member

@hifi hifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 👍

@droidmonkey droidmonkey merged commit 4178e72 into develop Mar 23, 2022
@droidmonkey droidmonkey deleted the hotfix/autotype-delay branch March 23, 2022 20:15
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Auto-Type pr: backported Pull request backported to previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-Type window filtering has a delay since 2.7.0
4 participants