-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce delay when searching entries in Auto-Type select dialog #7598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Built and tested on my system, works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one issue, need to make the delay a shared const as well.
4fda468
to
2fee61a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7598 +/- ##
===========================================
+ Coverage 64.24% 64.27% +0.02%
===========================================
Files 340 340
Lines 43465 43468 +3
===========================================
+ Hits 27923 27935 +12
+ Misses 15542 15533 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it 👍
Testing strategy
Tested on Windows
Type of change