Fix detection of hardware keys in keepassxc-cli #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
bug
feature: Hardware Keys
pr: backport pending
droidmonkey
commented
Mar 22, 2022
droidmonkey
commented
Mar 22, 2022
droidmonkey
commented
Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## develop #7593 +/- ##
===========================================
+ Coverage 64.24% 64.25% +0.01%
===========================================
Files 340 340
Lines 43463 43444 -19
===========================================
- Hits 27920 27912 -8
+ Misses 15543 15532 -11
Continue to review full report at Codecov.
|
droidmonkey
force-pushed
the
hotfix/yubikey-cli
branch
2 times, most recently
from
fad7360 to
4ec9664
Compare
Also correct / remove various debug messages
droidmonkey
force-pushed
the
hotfix/yubikey-cli
branch
2 times, most recently
from
85166f0 to
000af44
Compare
|
@phoerious ready for final |
* Split calls to finding hardware keys into sync and async methods. This has the side effect of simplifying the code. * Check for keys before performing challenge/response if no keys have been found previously. * Correct timeout of user interaction message to interact with the hardware key. * Correct error in TestCli::testYubiKeyOption
droidmonkey
force-pushed
the
hotfix/yubikey-cli
branch
from
000af44 to
896ba5c
Compare
phoerious
approved these changes
Apr 3, 2022
droidmonkey
added
pr: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was at it, I also disabled debug messages in release builds.
Testing strategy
Tested with both GUI and CLI using interaction required and passive modes on YubiKey.
Type of change