Generate the D-Bus adaptor class on the fly #7523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
approved these changes
Mar 12, 2022
There was a problem hiding this comment.
@droidmonkey Do we want to merge this into 2.7 oder defer to 2.8?
|
We can do this now, just need to add to changelog that we are now properly using the org.keepassxc.KeePassXC namespace on our dbus interface. Also need to test that, but not to hard to do |
|
Hmm, should I rebase this to 2.7? |
|
Yes please. Tested this and it works perfectly. |
That prevents mismatches between the adaptor class and the D-Bus definition file. Note that this is a backward-incompatible change. For example, the command to lock all databases is changed from > dbus-send --session --print-reply --dest=org.keepassxc.KeePassXC.MainWindow --type=method_call /keepassxc org.keepassxc.MainWindow.lockAllDatabases to > dbus-send --session --print-reply --dest=org.keepassxc.KeePassXC.MainWindow --type=method_call /keepassxc org.keepassxc.KeePassXC.MainWindow.lockAllDatabases Fixes: #5355
|
Thanks, done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.7.0 #7523 +/- ##
=================================================
+ Coverage 64.25% 64.26% +0.01%
=================================================
Files 341 340 -1
Lines 43416 43400 -16
=================================================
- Hits 27893 27889 -4
+ Misses 15523 15511 -12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
droidmonkey
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That prevents mismatches between the adaptor class and the D-Bus
definition file.
Note that this is a backward-incompatible change. For example, the
command to lock all databases is changed from
to
Fixes: #5355
Screenshots
N/A
Testing strategy
Manually with dbus-send commands mentioned in the commit message
Type of change