Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes for Auto-Type #7507

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Several fixes for Auto-Type #7507

merged 2 commits into from
Mar 19, 2022

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Mar 8, 2022

  • On Windows, offer explicit methods to use the virtual keyboard style of typing. This partially reverts 1150b69 by going back to the standard unicode method by default. However, uses can either add {MODE=VIRTUAL} to their sequence or choose "Use Virtual Keyboard" / CTRL+4 from the selection dialog.

  • Took this opportunity to clean up the signature of AutoType::performAutoType and AutoType::performAutoTypeWithSequence by removing the "hideWindow" attribute.

  • Show keyboard shortcuts on the selection dialog context menu

  • Fix selection dialog help icon color when in dark theme

  • Fix Auto-type failed to input tilde as a last pasword's character #7491

Also remove two unused/duplicate icons in separate commit.

Screenshots

autotype_selection_dialog_type_menu

Testing strategy

Tested on Windows using VirtualBox and normal applications.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

* On Windows, offer explicit methods to use the virtual keyboard style of typing. This partially reverts 1150b69 by going back to the standard unicode method by default. However, uses can either add {MODE=VIRTUAL} to their sequence or choose "Use Virtual Keyboard" / CTRL+4 from the selection dialog.

* Took this opportunity to clean up the signature of  AutoType::performAutoType and AutoType::performAutoTypeWithSequence by removing the "hideWindow" attribute.

* Show keyboard shortcuts on the selection dialog context menu

* Fix selection dialog help icon color when in dark theme
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #7507 (e6fb363) into release/2.7.0 (0ad75cc) will increase coverage by 0.00%.
The diff coverage is 27.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/2.7.0    #7507   +/-   ##
==============================================
  Coverage          64.24%   64.24%           
==============================================
  Files                341      341           
  Lines              43418    43436   +18     
==============================================
+ Hits               27892    27905   +13     
- Misses             15526    15531    +5     
Impacted Files Coverage Δ
src/autotype/AutoType.h 100.00% <ø> (ø)
src/autotype/AutoTypeAction.cpp 63.64% <0.00%> (-14.14%) ⬇️
src/autotype/AutoTypeAction.h 43.75% <ø> (ø)
src/autotype/AutoTypeSelectDialog.cpp 0.00% <0.00%> (ø)
src/gui/DatabaseWidget.cpp 61.74% <0.00%> (ø)
src/autotype/AutoType.cpp 71.85% <35.29%> (-2.73%) ⬇️
src/gui/entry/EditEntryWidget.cpp 72.23% <100.00%> (ø)
src/core/Entry.cpp 82.76% <0.00%> (+0.20%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad75cc...e6fb363. Read the comment docs.

Copy link
Member

@hifi hifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No immediate regressions on Linux, can't test Windows. LGTM otherwise.

@michaelk83
Copy link

michaelk83 commented Mar 8, 2022

choose "Use Virtual Keyboard" / CTRL+4 from the selection dialog.

Rather than placing that in the drop-down, maybe use a separate checkbox? So that you could still do Type {...} in virtual keyboard mode.

@droidmonkey
Copy link
Member Author

droidmonkey commented Mar 8, 2022

Considered it, but it adds clutter to the UI and you should only use the virtual keyboard in specific circumstances. It does break in not-so-edge cases due to Windows being shit at internationalization. Going to leave it as is for now.

@hifi
Copy link
Member

hifi commented Mar 8, 2022

... So that you could still do Type {...} in virtual keyboard mode.

This is a bit kludgey but you can use the {MODE=VIRTUAL} in an entry sequence (duplicate or main) to get more options in the dialog.

@droidmonkey
Copy link
Member Author

Tested on macOS and there are no regressions, works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants