-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixes for Auto-Type #7507
Conversation
* On Windows, offer explicit methods to use the virtual keyboard style of typing. This partially reverts 1150b69 by going back to the standard unicode method by default. However, uses can either add {MODE=VIRTUAL} to their sequence or choose "Use Virtual Keyboard" / CTRL+4 from the selection dialog. * Took this opportunity to clean up the signature of AutoType::performAutoType and AutoType::performAutoTypeWithSequence by removing the "hideWindow" attribute. * Show keyboard shortcuts on the selection dialog context menu * Fix selection dialog help icon color when in dark theme
558bcad
to
e6fb363
Compare
Codecov Report
@@ Coverage Diff @@
## release/2.7.0 #7507 +/- ##
==============================================
Coverage 64.24% 64.24%
==============================================
Files 341 341
Lines 43418 43436 +18
==============================================
+ Hits 27892 27905 +13
- Misses 15526 15531 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No immediate regressions on Linux, can't test Windows. LGTM otherwise.
Rather than placing that in the drop-down, maybe use a separate checkbox? So that you could still do |
Considered it, but it adds clutter to the UI and you should only use the virtual keyboard in specific circumstances. It does break in not-so-edge cases due to Windows being shit at internationalization. Going to leave it as is for now. |
This is a bit kludgey but you can use the |
Tested on macOS and there are no regressions, works great! |
On Windows, offer explicit methods to use the virtual keyboard style of typing. This partially reverts 1150b69 by going back to the standard unicode method by default. However, uses can either add {MODE=VIRTUAL} to their sequence or choose "Use Virtual Keyboard" / CTRL+4 from the selection dialog.
Took this opportunity to clean up the signature of AutoType::performAutoType and AutoType::performAutoTypeWithSequence by removing the "hideWindow" attribute.
Show keyboard shortcuts on the selection dialog context menu
Fix selection dialog help icon color when in dark theme
Fix Auto-type failed to input tilde as a last pasword's character #7491
Also remove two unused/duplicate icons in separate commit.
Screenshots
Testing strategy
Tested on Windows using VirtualBox and normal applications.
Type of change