Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly press AltGr key in Windows Auto-Type #7463

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

droidmonkey
Copy link
Member

Screenshots

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.24%. Comparing base (f3b0fe4) to head (8d2a72c).

Additional details and impacted files
@@              Coverage Diff               @@
##           release/2.7.0    #7463   +/-   ##
==============================================
  Coverage          64.24%   64.24%           
==============================================
  Files                341      341           
  Lines              43407    43407           
==============================================
+ Hits               27883    27884    +1     
+ Misses             15524    15523    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@phoerious phoerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Bug is not reproducible on Windows 11, but it seems like this fix also doesn't break anything there.

@droidmonkey droidmonkey merged commit e854250 into release/2.7.0 Feb 25, 2022
@droidmonkey droidmonkey deleted the hotfix/autotype-altgr-win branch February 25, 2022 11:05
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants