Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of database tag view in main window #7436

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Feb 19, 2022

  • Fix a bunch of styling issues with the tags interface
  • Also allow collapsing the entire left splitter instead of a dedicated option to hide the group view.

Screenshots

BEFORE:
image

AFTER:
image

image

Testing strategy

Tested using light and dark themes

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added this to the v2.7.0 milestone Feb 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #7436 (6e094ab) into develop (d10c5a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #7436   +/-   ##
========================================
  Coverage    64.33%   64.33%           
========================================
  Files          339      339           
  Lines        43216    43210    -6     
========================================
- Hits         27802    27799    -3     
+ Misses       15414    15411    -3     
Impacted Files Coverage Δ
src/core/Config.cpp 89.70% <ø> (ø)
src/core/Config.h 100.00% <ø> (ø)
src/gui/MainWindow.cpp 72.53% <ø> (+0.05%) ⬆️
src/gui/group/GroupView.cpp 73.63% <ø> (-0.60%) ⬇️
src/gui/DatabaseWidget.cpp 61.87% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10c5a4...6e094ab. Read the comment docs.

* Also allow collapsing the entire left splitter instead of a dedicated option to hide the group view.
@droidmonkey droidmonkey merged commit 0701d1d into develop Feb 20, 2022
@droidmonkey droidmonkey deleted the fix/tags-style branch February 20, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants