Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Type: Allow retyping with automatic relock #7435

Merged

Conversation

hifi
Copy link
Member

@hifi hifi commented Feb 19, 2022

If relock after performing Auto-Type is enabled it will wait until specified timeout before doing so.

Retype time is now configurable and is decreased from the old hardcoded 30 seconds down to 15 seconds to keep the default a bit more secure while still allowing the user to set it higher for their liking.

To restore old behavior the user can set retype time to 0 which will make the database relock instantly.

Auto-Type relock setting relocated to Auto-Type tab to group it better with the other Auto-Type settings.

Qt Designer botched the settings UI file a bit, sorry.

Screenshots

New setting:
image

Testing strategy

Manually on Linux. Tested that relocking with a timer while having the Auto-Type dialog open also closes it correctly (rejecting the dialog).

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)
  • ✅ New feature (change that adds functionality)

@hifi hifi added this to the v2.7.0 milestone Feb 19, 2022
@hifi hifi requested a review from droidmonkey February 19, 2022 21:01
@hifi hifi force-pushed the feature/autotype-retype-time-config branch from e8a25b0 to 20dbb31 Compare February 20, 2022 03:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #7435 (0c36c79) into develop (d10c5a4) will decrease coverage by 0.01%.
The diff coverage is 46.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7435      +/-   ##
===========================================
- Coverage    64.33%   64.33%   -0.01%     
===========================================
  Files          339      339              
  Lines        43216    43221       +5     
===========================================
+ Hits         27802    27803       +1     
- Misses       15414    15418       +4     
Impacted Files Coverage Δ
src/autotype/AutoType.h 100.00% <ø> (ø)
src/core/Config.cpp 89.70% <ø> (ø)
src/core/Config.h 100.00% <ø> (ø)
src/gui/ApplicationSettingsWidget.cpp 52.99% <25.00%> (-0.28%) ⬇️
src/autotype/AutoType.cpp 74.58% <50.00%> (-0.30%) ⬇️
src/gui/DatabaseTabWidget.cpp 62.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10c5a4...0c36c79. Read the comment docs.

If relock after performing Auto-Type is enabled it will wait until
specified timeout before doing so.

Retype time is now configurable and is decreased from the old
hardcoded 30 seconds down to 15 seconds to keep the default a bit
more secure while still allowing the user to set it higher for
their liking.

To restore old behavior the user can set retype time to 0 which
will make the database relock instantly.

Auto-Type relock setting relocated to Auto-Type tab to group it
better with the other Auto-Type settings.
@hifi hifi force-pushed the feature/autotype-retype-time-config branch from 20dbb31 to 0c36c79 Compare February 20, 2022 04:24
@michaelk83
Copy link

Retype time is now configurable and is decreased from the old hardcoded 30 seconds down to 15 seconds to keep the default a bit more secure

May want to add a tooltip there explaining the security implications. It's not at all clear that there are any from just the setting text.

@hifi
Copy link
Member Author

hifi commented Feb 20, 2022

Retype time is now configurable and is decreased from the old hardcoded 30 seconds down to 15 seconds to keep the default a bit more secure

May want to add a tooltip there explaining the security implications. It's not at all clear that there are any from just the setting text.

Tooltips aren't extremely discoverable (anymore) and the security implications are minimal and only relates to the relock after Auto-Type setting being delayed by 15 seconds by default which leaves very little room for any kind of eavesdropping.

@michaelk83
Copy link

Ideally there should be an (i) icon when there's a tooltip available (at least for the important ones), but that's more of a system-wide change.

@droidmonkey droidmonkey merged commit bfbc0e5 into keepassxreboot:develop Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants