-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Type: Allow retyping with automatic relock #7435
Auto-Type: Allow retyping with automatic relock #7435
Conversation
e8a25b0
to
20dbb31
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7435 +/- ##
===========================================
- Coverage 64.33% 64.33% -0.01%
===========================================
Files 339 339
Lines 43216 43221 +5
===========================================
+ Hits 27802 27803 +1
- Misses 15414 15418 +4
Continue to review full report at Codecov.
|
If relock after performing Auto-Type is enabled it will wait until specified timeout before doing so. Retype time is now configurable and is decreased from the old hardcoded 30 seconds down to 15 seconds to keep the default a bit more secure while still allowing the user to set it higher for their liking. To restore old behavior the user can set retype time to 0 which will make the database relock instantly. Auto-Type relock setting relocated to Auto-Type tab to group it better with the other Auto-Type settings.
20dbb31
to
0c36c79
Compare
May want to add a tooltip there explaining the security implications. It's not at all clear that there are any from just the setting text. |
Tooltips aren't extremely discoverable (anymore) and the security implications are minimal and only relates to the relock after Auto-Type setting being delayed by 15 seconds by default which leaves very little room for any kind of eavesdropping. |
Ideally there should be an (i) icon when there's a tooltip available (at least for the important ones), but that's more of a system-wide change. |
If relock after performing Auto-Type is enabled it will wait until specified timeout before doing so.
Retype time is now configurable and is decreased from the old hardcoded 30 seconds down to 15 seconds to keep the default a bit more secure while still allowing the user to set it higher for their liking.
To restore old behavior the user can set retype time to 0 which will make the database relock instantly.
Auto-Type relock setting relocated to Auto-Type tab to group it better with the other Auto-Type settings.
Qt Designer botched the settings UI file a bit, sorry.
Screenshots
New setting:
Testing strategy
Manually on Linux. Tested that relocking with a timer while having the Auto-Type dialog open also closes it correctly (rejecting the dialog).
Type of change