Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Type: Only match non-empty associations #7391

Merged

Conversation

hifi
Copy link
Member

@hifi hifi commented Feb 7, 2022

Previously empty associations matched any window but since you can use a wildcard (*) if you specifically want that this change makes it possible to define multiple sequences for the global search if you need to.

Additionally show empty associations in the list as "(empty)" to better differentiate between rows if no title is set.

This trivial change makes #6869 possible without touching the dialog code.

Screenshots

image
image

Testing strategy

Manually on Linux.

Type of change

  • ✅ New feature (change that adds functionality)
  • ✅ Breaking change (causes existing functionality to change)

@hifi hifi added this to the v2.7.0 milestone Feb 7, 2022
@hifi hifi requested a review from droidmonkey February 7, 2022 07:46
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #7391 (530d023) into develop (86ba58d) will decrease coverage by 0.01%.
The diff coverage is 66.67%.

❗ Current head 530d023 differs from pull request most recent head 17fe36f. Consider uploading reports for the commit 17fe36f to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7391      +/-   ##
===========================================
- Coverage    64.33%   64.32%   -0.01%     
===========================================
  Files          339      339              
  Lines        43195    43197       +2     
===========================================
- Hits         27787    27785       -2     
- Misses       15408    15412       +4     
Impacted Files Coverage Δ
src/gui/entry/AutoTypeAssociationsModel.cpp 91.67% <50.00%> (-1.19%) ⬇️
src/core/Entry.cpp 82.55% <100.00%> (-0.20%) ⬇️
src/core/FileWatcher.cpp 85.54% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ba58d...17fe36f. Read the comment docs.

Previously empty associations matched any window but since you can
use a wildcard (*) if you specifically want that this change makes
it possible to define multiple sequences for the global search
if you need to.

Additionally show empty associations in the list as "(empty)" to
better differentiate between rows if no title is set.
@hifi hifi force-pushed the fix/match-non-empty-associations branch from 530d023 to 17fe36f Compare February 7, 2022 10:53
@anantakrishna
Copy link

It seems that this documentation should have been changed as a part of this PR:

Leave the window title blank to offer additional default Auto-Type sequences, such as custom attributes.
https://github.com/keepassxreboot/keepassxc/blob/develop/docs/topics/AutoType.adoc

If that's correct, I can try sending a PR for this. Please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants