Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two Auto-Type issues #7366

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Fix two Auto-Type issues #7366

merged 2 commits into from
Feb 9, 2022

Conversation

droidmonkey
Copy link
Member

Note: Extended ASCII and Unicode characters cannot be sent to Virtual Machines. I tried many combinations of the windows virtual keyboard API and couldn't get it to work without breaking other major parts.

Screenshots

2022-02-01_07-25-16

Testing strategy

Tested on Windows using Virtual Box.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

* Fix error in regex that prevented use of modifier keys in general.
* Added '#' modifier to press the "Meta" button. This correlates to the Windows key on Windows and Command key on macOS.
* Fix #6695 - send proper modifier keys based on documentation
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #7366 (c56ebe5) into develop (07564d5) will increase coverage by 0.00%.
The diff coverage is 66.67%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #7366   +/-   ##
========================================
  Coverage    64.33%   64.33%           
========================================
  Files          339      339           
  Lines        43195    43197    +2     
========================================
+ Hits         27787    27789    +2     
  Misses       15408    15408           
Impacted Files Coverage Δ
src/autotype/AutoType.cpp 74.88% <66.67%> (+0.36%) ⬆️
src/core/FileWatcher.cpp 85.54% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07564d5...c56ebe5. Read the comment docs.

Copy link
Member

@hifi hifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New meta modifier works on Linux 👍

Don't have a working Windows build env so can't say about the changes on that side.

@droidmonkey droidmonkey merged commit 58615d7 into develop Feb 9, 2022
@droidmonkey droidmonkey deleted the fix/autotype-fixes branch February 9, 2022 00:07
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Auto-Type pr: bugfix Pull request that fixes a bug
Projects
None yet
4 participants